Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/auditbeat/module/socket/guess: fix creds trigger for newer kernels #37136

Merged
merged 1 commit into from
Nov 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]
*Auditbeat*

- Fix documentation regarding socket type selection. {issue}37174[37174] {pull}37175[37175]
- Fix guess trigger for system/socket creds on newer kernels. {issue}36905[36905] {pull}37136[37136]

*Filebeat*

Expand Down
50 changes: 37 additions & 13 deletions x-pack/auditbeat/module/system/socket/guess/creds.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,17 @@ import (
"github.com/elastic/elastic-agent-libs/mapstr"
)

/*
struct mq_attr {
long mq_flags;
long mq_maxmsg;
long mq_msgsize;
long mq_curmsgs;
long __reserved[4];
};
*/
import "C"

/*
creds guess discovers the offsets of (E)UID/(E)GID fields within a
struct cred (defined in {linux}/include/linux.cred.h):
Expand Down Expand Up @@ -77,20 +88,20 @@ func (g *guessStructCreds) Provides() []string {
// Requires declares the variables required to run this guess.
func (g *guessStructCreds) Requires() []string {
return []string{
"RET",
"P3",
}
}

// Probes returns a kretprobe on prepare_creds that dumps the first bytes
// pointed to by the return value, which is a struct cred.
// Probes returns a kprobe on dentry_open that dumps the first bytes
// pointed to by the third parameter value, which is a struct cred.
func (g *guessStructCreds) Probes() ([]helper.ProbeDef, error) {
return []helper.ProbeDef{
{
Probe: tracing.Probe{
Type: tracing.TypeKRetProbe,
Type: tracing.TypeKProbe,
Name: "guess_struct_creds",
Address: "prepare_creds",
Fetchargs: helper.MakeMemoryDump("{{.RET}}", 0, credDumpBytes),
Address: "dentry_open",
Fetchargs: helper.MakeMemoryDump("{{.P3}}", 0, credDumpBytes),
},
Decoder: tracing.NewDumpDecoder,
},
Expand Down Expand Up @@ -138,13 +149,26 @@ func (g *guessStructCreds) Extract(ev interface{}) (mapstr.M, bool) {
}, true
}

// Trigger invokes the SYS_ACCESS syscall:
//
// int access(const char *pathname, int mode);
// Trigger invokes the SYS_MQ_OPEN syscall:
//
// The function call will return an error due to path being NULL, but it will
// have invoked prepare_creds before argument validation.
// int mq_open(const char *name, int oflag, mode_t mode, struct mq_attr *attr);
func (g *guessStructCreds) Trigger() error {
syscall.Syscall(unix.SYS_ACCESS, 0, 0, 0)
return nil
name, err := unix.BytePtrFromString("__guess_creds")
if err != nil {
return err
}
attr := C.struct_mq_attr{
mq_maxmsg: 1,
mq_msgsize: 8,
}
mqd, _, errno := syscall.Syscall6(unix.SYS_MQ_OPEN,
uintptr(unsafe.Pointer(name)),
uintptr(os.O_CREATE|os.O_RDWR),
0o644,
uintptr(unsafe.Pointer(&attr)),
0, 0)
if errno != 0 {
return errno
}
return unix.Close(int(mqd))
}
14 changes: 12 additions & 2 deletions x-pack/auditbeat/seccomp_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,22 @@ func init() {
// The system/package dataset uses librpm which has additional syscall
// requirements beyond the default policy from libbeat so whitelist
// these additional syscalls.
if err := seccomp.ModifyDefaultPolicy(seccomp.AddSyscall, "umask", "mremap"); err != nil {
if err := seccomp.ModifyDefaultPolicy(seccomp.AddSyscall,
"mremap",
"umask",
); err != nil {
Comment on lines +19 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solely whitespace changes would be nicer in a second commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but unfortunately this will all get squashed.

panic(err)
}

// The system/socket dataset uses additional syscalls
if err := seccomp.ModifyDefaultPolicy(seccomp.AddSyscall, "perf_event_open", "eventfd2", "ppoll", "mount", "umount2"); err != nil {
if err := seccomp.ModifyDefaultPolicy(seccomp.AddSyscall,
"eventfd2",
"mount",
"mq_open", // required for creds kprobe guess trigger.
"perf_event_open",
"ppoll",
"umount2",
); err != nil {
panic(err)
}
}
Expand Down
Loading