Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbeat/processors/add_process_metadata: fix environment collection #36471

Merged
merged 1 commit into from
Sep 5, 2023
Merged

libbeat/processors/add_process_metadata: fix environment collection #36471

merged 1 commit into from
Sep 5, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 31, 2023

Proposed commit message

Previously, the go-sysinfo types.Process was not being queried for its environment value if it existed. This is conditionally available depending on platform, so check and add it if it is.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 self-assigned this Aug 31, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 31, 2023
@efd6
libbeat/processors/add_process_metadata: fix environment collection
2f9b7f5 
Previously, the go-sysinfo types.Process was not being queried for its
environment value if it existed. This is conditionally available
depending on platform, so check and add it if it is.
@efd6 efd6 force-pushed the 36469-add_process_metadata branch from 72287bd to 2f9b7f5 Compare August 31, 2023 03:12
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-31T03:13:24.371+0000

  • Duration: 72 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 28077
Skipped 2015
Total 30092

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review August 31, 2023 04:32
@efd6 efd6 requested a review from a team as a code owner August 31, 2023 04:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh added backport-v8.10.0 Automated backport with mergify and removed backport-v8.1.0 Automated backport with mergify labels Aug 31, 2023
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 5, 2023
@efd6 efd6 merged commit 1209bca into elastic:main Sep 5, 2023
85 of 87 checks passed
mergify bot pushed a commit that referenced this pull request Sep 5, 2023
@efd6 @mergify
libbeat/processors/add_process_metadata: fix environment collection (#…
0f32cce 
…36471)

Previously, the go-sysinfo types.Process was not being queried for its
environment value if it existed. This is conditionally available
depending on platform, so check and add it if it is.

(cherry picked from commit 1209bca)
@mergify mergify bot mentioned this pull request Sep 5, 2023
Merged
efd6 added a commit that referenced this pull request Sep 5, 2023
@mergify @efd6
libbeat/processors/add_process_metadata: fix environment collection (#…
685c7f0 
…36471) (#36503)

Previously, the go-sysinfo types.Process was not being queried for its
environment value if it existed. This is conditionally available
depending on platform, so check and add it if it is.

(cherry picked from commit 1209bca)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
libbeat/processors/add_process_metadata: fix environment collection (e…
6a71bdd 
…lastic#36471)

Previously, the go-sysinfo types.Process was not being queried for its
environment value if it existed. This is conditionally available
depending on platform, so check and add it if it is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr belimawr approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
8.11-candidate backport-v8.10.0 Automated backport with mergify bug libbeat Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add_process_metadata - process.env enrichment not working
5 participants
@efd6 @elasticmachine @belimawr @andrewkroh @pierrehilbert