Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat][httpjson] - Fix input metric name #36169

Merged
merged 5 commits into from
Jul 29, 2023
Merged

[filebeat][httpjson] - Fix input metric name #36169

merged 5 commits into from
Jul 29, 2023

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Jul 28, 2023 •
edited
Loading

Type of change

  • Bug

What does this PR do?

It changes the input metric name of httpjson_interval_pages_total to httpjson_interval_pages

Why is it important?

This is done to address this particular issue: #35933

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
  • I have made my commit title and message explanatory about the purpose and the reason of the change

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ShourieG ShourieG requested a review from a team as a code owner July 28, 2023 13:55
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 28, 2023
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label Team:Security-External Integrations and removed Team:Cloud-Security-Posture The CSP team labels Jul 28, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 28, 2023
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label backport-v8.9.0 Automated backport with mergify labels Jul 28, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 28, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 28, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-28T17:48:14.662+0000

  • Duration: 79 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 3078
Skipped 178
Total 3256

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh andrewkroh mentioned this pull request Jul 28, 2023
Closed
@ShourieG @andrewkroh
Update CHANGELOG-developer.next.asciidoc
99499e5 
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@ShourieG ShourieG merged commit 3c807b0 into elastic:main Jul 29, 2023
8 checks passed
@ShourieG ShourieG deleted the bugfix/httpjson_metrics branch July 29, 2023 01:13
mergify bot pushed a commit that referenced this pull request Jul 29, 2023
@ShourieG @mergify
[filebeat][httpjson] - Fix input metric name (#36169)
d756dd0 
* fixed httpjson input metric naming convention to solve parsing error in fleet

* fixed httpjson input metric naming convention to solve parsing error in fleet

* updated asciidoc with issue and pr description

* Update CHANGELOG-developer.next.asciidoc

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>

---------

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
(cherry picked from commit 3c807b0)
@mergify mergify bot mentioned this pull request Jul 29, 2023
Merged
ShourieG added a commit that referenced this pull request Jul 29, 2023
@mergify @ShourieG
[filebeat][httpjson] - Fix input metric name (#36169) (#36172)
0ddfb1e 
* fixed httpjson input metric naming convention to solve parsing error in fleet

* fixed httpjson input metric naming convention to solve parsing error in fleet

* updated asciidoc with issue and pr description

* Update CHANGELOG-developer.next.asciidoc

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>

---------

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
(cherry picked from commit 3c807b0)

Co-authored-by: ShourieG <105607378+ShourieG@users.noreply.github.com>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@ShourieG @andrewkroh @Scholar-Li
[filebeat][httpjson] - Fix input metric name (elastic#36169)
e62e62c 
* fixed httpjson input metric naming convention to solve parsing error in fleet

* fixed httpjson input metric naming convention to solve parsing error in fleet

* updated asciidoc with issue and pr description

* Update CHANGELOG-developer.next.asciidoc

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>

---------

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@ShourieG ShourieG

Labels
backport-v8.9.0 Automated backport with mergify bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShourieG @elasticmachine @andrewkroh