Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing activemq tests #35852

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jun 21, 2023

Skip the activemq test suite until we can determine why the tests are failing.

@cmacknz cmacknz added the Team:Services (Deprecated) Label for the former Integrations-Services team label Jun 21, 2023
@cmacknz cmacknz self-assigned this Jun 21, 2023
@cmacknz cmacknz requested a review from a team as a code owner June 21, 2023 13:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @cmacknz? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@cmacknz cmacknz added backport-v8.8.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Jun 21, 2023
@shmsr
Copy link
Member

shmsr commented Jun 21, 2023

Approving this as we need to debug this.

@cmacknz Is it because of this 62374dd because there were some Python-related changes? I'll also debug on what's happening but haven't found it.

@cmacknz
Copy link
Member Author

cmacknz commented Jun 21, 2023

@cmacknz Is it because of this 62374dd because there were some Python-related changes? I'll also debug on what's happening but haven't found it.

I suppose it is possible, I swear I had the these test pass after rerunning that test suite but it looks like the results may have just been delayed.

The odd thing is that there were no changes to activemq at all. If you start only the activemq container it never becomes healthy.

cd x-pack/metricbeat/module/activemq
docker-compose up

The health check that is failing is:

HEALTHCHECK --interval=1s --retries=90 CMD nc -w 1 -v 127.0.0.1 $ACTIVEMQ_STOMP </dev/null && \
nc -w 1 -v 127.0.0.1 $ACTIVEMQ_REST </dev/null

If you run this in the container started manually it fails with no output.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T13:54:51.349+0000

  • Duration: 54 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 1419
Skipped 96
Total 1515

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz cmacknz merged commit 16699bc into elastic:main Jun 21, 2023
7 checks passed
@cmacknz cmacknz deleted the disable-failing-activemq-tests branch June 21, 2023 14:49
mergify bot pushed a commit that referenced this pull request Jun 21, 2023
* Disable failing activemq tests.

* Disable failing activemq tests.

(cherry picked from commit 16699bc)
mergify bot pushed a commit that referenced this pull request Jun 21, 2023
* Disable failing activemq tests.

* Disable failing activemq tests.

(cherry picked from commit 16699bc)
cmacknz added a commit that referenced this pull request Jun 21, 2023
* Disable failing activemq tests.

* Disable failing activemq tests.

(cherry picked from commit 16699bc)

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
cmacknz added a commit that referenced this pull request Jun 21, 2023
* Disable failing activemq tests.

* Disable failing activemq tests.

(cherry picked from commit 16699bc)

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
@shmsr
Copy link
Member

shmsr commented Jun 22, 2023

@cmacknz Is it because of this 62374dd because there were some Python-related changes? I'll also debug on what's happening but haven't found it.

I suppose it is possible, I swear I had the these test pass after rerunning that test suite but it looks like the results may have just been delayed.

The odd thing is that there were no changes to activemq at all. If you start only the activemq container it never becomes healthy.

cd x-pack/metricbeat/module/activemq
docker-compose up

The health check that is failing is:

HEALTHCHECK --interval=1s --retries=90 CMD nc -w 1 -v 127.0.0.1 $ACTIVEMQ_STOMP </dev/null && \
nc -w 1 -v 127.0.0.1 $ACTIVEMQ_REST </dev/null

If you run this in the container started manually it fails with no output.

Oh, okay. I'll also take a look.

@reakaleek reakaleek mentioned this pull request Jul 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.8.0 Automated backport with mergify Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants