Use the Beat version in the Ingest Node pipeline #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
changed the title
ruflin
reviewed
Feb 2, 2017
filebeat/fileset/fileset_test.go
Outdated
| @@ -183,17 +183,17 @@ func TestGetProspectorConfigNginxOverrides(t *testing.T) { | |||
| assert.True(t, cfg.HasField("pipeline")) | |||
| pipelineID, err := cfg.String("pipeline", -1) | |||
| assert.NoError(t, err) | |||
| assert.Equal(t, "nginx-access-with_plugins", pipelineID) | |||
| assert.Equal(t, "nginx-access-with_plugins-5.2.0", pipelineID) | |||
There was a problem hiding this comment.
I would call the pipeline filebeat-5.2.0-nginx-access-with_plugins. This brings the following benefits:
- No conflict with potential pipelines in the future from other beats
- Assuming some can query for pipelines, to get / remove all filebeat pipelines
filebeat-*can be used, to remove all5.2pipelines because everyting is using 5.3,filebeat-5.2.*can be used.
tsg
force-pushed
the
filebeat_modules_pipeline_version
branch
3 times, most recently
from
c5a25c2
to
4afb574
Compare
This adds the Beat version to the pipeline ID, which means that if we change the pipeline between versions, the new version will be used automatically. It also means that one can run different versions of the same Beat and the pipelines won't override each other. The pipelines are loaded automatically on the Beat start. Part of elastic#3159.
tsg
force-pushed
the
filebeat_modules_pipeline_version
branch
from
4afb574
to
5a5b20d
Compare
ruflin
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Beat version to the pipeline ID, which means that if
we change the pipeline between versions, the new version will be used
automatically. It also means that one can run different versions of the
same Beat and the pipelines won't override each other. The pipelines
are loaded automatically on the Beat start.
Part of #3159.