Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0](backport #28596) [breaking] Make default_field: false the default for all fields #28855

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 6, 2021

This is an automatic backport of pull request #28596 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Changes the default value of the default_field flag in fields definitions to false. This means that only fields that are explicitly marked with default_fields: true (or their subfields) will be added to the index template's setting.index.query.default_field list.

After this PR, all fields are excluded from default_field, except:

- Selected fields from ECS. The ECS team maintains the list of fields that are included.
- Fields for processors.
- Fields for Filebeat inputs.

(cherry picked from commit 84e668c)
@mergify mergify bot requested a review from a team as a code owner November 6, 2021 15:30
@mergify mergify bot added the backport label Nov 6, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 6, 2021
@botelastic
Copy link

botelastic bot commented Nov 6, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-06T15:30:45.541+0000

  • Duration: 177 min 11 sec

  • Commit: 28241b0

Test stats 🧪

Test Results
Failed 0
Passed 53988
Skipped 5346
Total 59334

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@adriansr adriansr merged commit ada8eae into 8.0 Nov 8, 2021
@adriansr adriansr deleted the mergify/bp/8.0/pr-28596 branch November 8, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants