Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] upgrade flatbuffers to 1.12.1 #28094

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

endorama
Copy link
Member

What does this PR do?

Version 1.12.0 seems to have changed, producing a verification error.

verifying github.com/google/flatbuffers@v1.12.0: checksum mismatch
        downloaded: h1:N8EguYFm2wwdpoNcpchQY0tPs85vOJkboFb2dPxmixo=
        go.sum:     h1:/PtAHvnBY4Kqnx/xCQ3OIV9uYcSFGScBsWI3Oogeh6w=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

As 1.12.1 is available, upgrading the module.

Why is it important?

Prevent an error when building x-pack/metricbeat

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Run mage build in x-pack/metricbeat

Related issues

Use cases

Screenshots

Logs

@endorama endorama added the Team:Integrations Label for the Integrations team label Sep 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 23, 2021
@endorama endorama changed the title upgrade flatbuffers to 1.12.1 [Metricbeat] upgrade flatbuffers to 1.12.1 Sep 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2021

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 23, 2021
@endorama endorama added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Sep 23, 2021
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-04T14:59:52.941+0000

  • Duration: 206 min 34 sec

  • Commit: 2db054b

Test stats 🧪

Test Results
Failed 0
Passed 54122
Skipped 5354
Total 59476

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@andrewkroh
Copy link
Member

Please run make notice from the root of the repo.

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b flatbuffers-1.12.1 upstream/flatbuffers-1.12.1
git merge upstream/master
git push upstream flatbuffers-1.12.1

@endorama
Copy link
Member Author

/test

@endorama
Copy link
Member Author

/test

@endorama
Copy link
Member Author

/test

1 similar comment
@endorama
Copy link
Member Author

/test

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@endorama
Copy link
Member Author

/test

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b flatbuffers-1.12.1 upstream/flatbuffers-1.12.1
git merge upstream/master
git push upstream flatbuffers-1.12.1

Version 1.12.0 seems to have changed, producing a verification error.

verifying github.com/google/flatbuffers@v1.12.0: checksum mismatch
        downloaded: h1:N8EguYFm2wwdpoNcpchQY0tPs85vOJkboFb2dPxmixo=
        go.sum:     h1:/PtAHvnBY4Kqnx/xCQ3OIV9uYcSFGScBsWI3Oogeh6w=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

As 1.12.1 is available, upgrading the module.
@endorama
Copy link
Member Author

endorama commented Nov 5, 2021

Finally all green! Merging.

@endorama endorama merged commit 5ee1964 into elastic:master Nov 5, 2021
@endorama endorama deleted the flatbuffers-1.12.1 branch November 5, 2021 09:06
endorama added a commit that referenced this pull request Nov 5, 2021
(cherry picked from commit 5ee1964)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
endorama added a commit that referenced this pull request Nov 5, 2021
(cherry picked from commit 5ee1964)

# Conflicts:
#	go.sum
mtojek pushed a commit that referenced this pull request Nov 8, 2021
(cherry picked from commit 5ee1964)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
endorama added a commit that referenced this pull request Nov 8, 2021
v1v added a commit to v1v/beats that referenced this pull request Nov 8, 2021
…in-the-package-binareis

* upstream/master:
  allows disable pod events enrichment with deployment name (elastic#28521)
  Remove Docker input from Filebeat (elastic#28817)
  [breaking] Make default_field: false the default for all fields (elastic#28596)
  Osquerybeat: Improve osquery client connect code (elastic#28848)
  Add crawler  metrics into the stats metricset for Enterprise Search (elastic#28790)
  Remove the now deprecated appsearch module from metricbeat (elastic#28850)
  Remove Beat generators (elastic#28816)
  chore: upload files to Google Storage when they exist (elastic#28836)
  Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elastic#28812)
  Deprecate generating custom Beats (elastic#28814)
  [Metricbeat] upgrade flatbuffers to 1.12.1 (elastic#28094)
  Osquerybeat: Fix restart flags after previously bad config (elastic#28827)
  Force ECS and JSON logging for libbeat/logp (elastic#28573)
  Filebeat: Error on startup for unconfigured module (elastic#28818)
  Deprecate log input in favour of filestream (elastic#28623)
  Fix some spelling mistakes (elastic#28080)
@endorama endorama added the backport-v8.0.0 Automated backport with mergify label Nov 11, 2021
@endorama
Copy link
Member Author

@Mergifyio refresh

mergify bot pushed a commit that referenced this pull request Nov 11, 2021
(cherry picked from commit 5ee1964)

# Conflicts:
#	go.sum
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2021

refresh

✅ Pull request refreshed

endorama added a commit that referenced this pull request Nov 15, 2021
(cherry picked from commit 5ee1964)

# Conflicts:
#	go.sum
endorama added a commit that referenced this pull request Nov 16, 2021
endorama added a commit that referenced this pull request Nov 16, 2021
endorama added a commit that referenced this pull request Nov 29, 2021
…8931)

Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
endorama added a commit that referenced this pull request Dec 3, 2021
…28835)

Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…in-the-package-binareis

* upstream/master:
  allows disable pod events enrichment with deployment name (elastic#28521)
  Remove Docker input from Filebeat (elastic#28817)
  [breaking] Make default_field: false the default for all fields (elastic#28596)
  Osquerybeat: Improve osquery client connect code (elastic#28848)
  Add crawler  metrics into the stats metricset for Enterprise Search (elastic#28790)
  Remove the now deprecated appsearch module from metricbeat (elastic#28850)
  Remove Beat generators (elastic#28816)
  chore: upload files to Google Storage when they exist (elastic#28836)
  Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elastic#28812)
  Deprecate generating custom Beats (elastic#28814)
  [Metricbeat] upgrade flatbuffers to 1.12.1 (elastic#28094)
  Osquerybeat: Fix restart flags after previously bad config (elastic#28827)
  Force ECS and JSON logging for libbeat/logp (elastic#28573)
  Filebeat: Error on startup for unconfigured module (elastic#28818)
  Deprecate log input in favour of filestream (elastic#28623)
  Fix some spelling mistakes (elastic#28080)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…8834)

(cherry picked from commit 251fc0b)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants