Fix async publisher sending empty events #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
needs_backport
| if event.HasData() { | ||
| tmpEvents = append(tmpEvents, event) | ||
| } | ||
| } |
There was a problem hiding this comment.
we need to copy here? the events array is store in eventsBatch for pushing acked events(batches) to registrar. Interestingly the syncPublisher does forward all events without filtering.
There was a problem hiding this comment.
No need to copy. I was thinking that eventsBatch also needs the filtered list, but if it is for the registrar this is not the case.
I simplified the implementation. Please have a look again.
The sync publisher also does the filtering on line 114.
ruflin
force-pushed
the
async-publisher
branch
from
a246b87
to
f9bcf97
Compare
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Sep 5, 2016
tsg
pushed a commit
that referenced
this pull request
Sep 7, 2016
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.