-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Run linting for only docs #23099
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Test | Results |
---|---|
Failed | 0 |
Passed | 17427 |
Skipped | 1379 |
Total | 18806 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on a fix for this!
Something I think we are also missing since #22103 is that some module docs files generated under filebeat/docs
and metricbeat/docs
depend on the docs of x-pack modules, and I think we are not triggering any OSS build after changes in x-pack.
Perhaps for that we should trigger a make check
in oss if x-pack is modified, but I am ok with doing it as a different change.
Yes, I'd prefer to create a specific issue for that particular scenario :) |
cmd(label: "make check-go", script: "make check-go") | ||
cmd(label: "Check for changes", script: "make check-no-changes") | ||
whenTrue(env.ONLY_DOCS == 'true') { | ||
cmd(label: "make check", script: "make check") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is possible to run the lint stage(Jenkinsfile.yml) of each beat? it is the same but in parallel so faster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's another approach to solve this issue:
- Either to exclude the ONLY_DOCS when in the Builds&Tests dynamic stages. But it will also run the build/tests stages, and if flaky tests then it might cause failed builds for only docs changes.
- Or this approach
That's the current implementation, but my aim with this PR was to avoid changing the current implementation but enabling the make check
only for the DOCS changes.
In both cases, the output is the same, I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's live with it, but takes 15 min :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only for docs
changes, if any kind of code changes, then it will work as used to be.
What does this PR do?
Run
make check
when there are only doc changes, otherwise, it keeps as usual.Why is it important?
Otherwise the linting is not executed since it's delegated to the specific beat which only run when no doc changes.
Related issues