Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packetbeat ipv6 #2254

Merged
merged 9 commits into from
Aug 23, 2016
Merged

Packetbeat ipv6 #2254

merged 9 commits into from
Aug 23, 2016

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Aug 12, 2016

As discussed in #1995 . The CLA is not yet signed, but expect that Real Soon Now, so code review welcome :)

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@raboof
Copy link
Contributor Author

raboof commented Aug 12, 2016

selection_106

@tsg
Copy link
Contributor

tsg commented Aug 15, 2016

@raboof LGTM, great contribution! While we wait for the CLA, can you also add a line in the CHANGELOG.asciidoc, please?

I added it under 'Breaking changes' as it might break consumers that assume
IP's to be in IPv4 format.
@raboof
Copy link
Contributor Author

raboof commented Aug 16, 2016

@karmi the Corporate CLA was 'Signed and Filed' (by Mark Bakker) this morning, are there any further steps I need to take? Do we need to do anything to make the bot aware of this?

@ruflin
Copy link
Member

ruflin commented Aug 17, 2016

@raboof The script can't verify corporate CLA's automatically. I did the manual check and all looks good.

@tsg
Copy link
Contributor

tsg commented Aug 23, 2016

jenkins, test it

@tsg
Copy link
Contributor

tsg commented Aug 23, 2016

I added it under 'Breaking changes' as it might break consumers that assume
IP's to be in IPv4 format.

I'm not sure I understand this, on my testing it's still using the IPV4 dotted format for IPs.

Also, the PR add support for matching processes when using IPv6, but the Changelog entry makes it sound like we added support for decoding IPv6 (which we already support).

@raboof
Copy link
Contributor Author

raboof commented Aug 23, 2016

@tsg you're right - I've updated the changelog, does that clarify things?

@tsg tsg merged commit 244c752 into elastic:master Aug 23, 2016
@tsg
Copy link
Contributor

tsg commented Aug 23, 2016

@raboof Wonderful! Thanks a lot for the contribution.

@raboof
Copy link
Contributor Author

raboof commented Aug 23, 2016

👍 thanks for the great framework & for taking our contribution :)

@raboof raboof deleted the packetbeat-ipv6 branch August 23, 2016 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants