Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build of Packetbeat test under windows/386 #22351

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Fix build of Packetbeat test under windows/386 #22351

merged 2 commits into from
Nov 2, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Nov 2, 2020

Fixes a constant overflow under 32-bit OS and re-enables testing under Windows 7 32bits.

Closes #22303

@adriansr adriansr added review Team:Automation Label for the Observability productivity team failed-test indicates a failed automation test relates labels Nov 2, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 2, 2020
@adriansr adriansr requested a review from v1v November 2, 2020 15:21
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 2, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1627
Skipped 15
Total 1642

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 2, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [v1v commented: jenkins run the tests please]

  • Start Time: 2020-11-02T16:43:54.521+0000

  • Duration: 62 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 1627
Skipped 15
Total 1642

@v1v
Copy link
Member

v1v commented Nov 2, 2020

jenkins run the tests please

@v1v v1v added the windows-7-32 Enable builds in the CI for windows-7 32 bits label Nov 2, 2020
v1v
v1v approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@adriansr adriansr merged commit 7bdfc15 into elastic:master Nov 2, 2020
@adriansr adriansr added the needs_backport PR is waiting to be backported to other branches. label Nov 16, 2020
@v1v
Copy link
Member

v1v commented Jan 27, 2021

@adriansr , I just found this issue, should it be backported to 7.x/7.11?

@adriansr adriansr mentioned this pull request Jan 29, 2021
Merged
@adriansr adriansr added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 29, 2021
@adriansr adriansr mentioned this pull request Jan 29, 2021
Merged
adriansr added a commit to adriansr/beats that referenced this pull request Jan 29, 2021
@adriansr
Fix build of Packetbeat test under windows/386 (elastic#22351)
d2268e5 
Constant overflowed 32-bit int.

Closes elastic#22303

(cherry picked from commit 7bdfc15)
andrewkroh pushed a commit that referenced this pull request Jan 29, 2021
@adriansr
Fix build of Packetbeat test under windows/386 (#22351) (#23750)
899a73c 
Constant overflowed 32-bit int.

Closes #22303

(cherry picked from commit 7bdfc15)
adriansr added a commit to adriansr/beats that referenced this pull request Jan 29, 2021
@adriansr
Fix build of Packetbeat test under windows/386 (elastic#22351)
49cbaa1 
Constant overflowed 32-bit int.

Closes elastic#22303

(cherry picked from commit 7bdfc15)
adriansr added a commit that referenced this pull request Jan 29, 2021
@adriansr
Fix build of Packetbeat test under windows/386 (#22351) (#23749)
918c894 
Constant overflowed 32-bit int.

Closes #22303

(cherry picked from commit 7bdfc15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v approved these changes

Assignees
No one assigned
Labels
failed-test indicates a failed automation test relates review Team:Automation Label for the Observability productivity team v7.11.0 v7.12.0 windows-7-32 Enable builds in the CI for windows-7 32 bits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[packetbeat][windows-7-32] got some failed tests for TestParseTableRaw
3 participants
@adriansr @elasticmachine @v1v