Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Kafka version 2.2 #22328

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Oct 30, 2020

What does this PR do?

Adds Kafka version 2.2 to the list of supported versions in code.

Why is it important?

It seems we are already testing with Kafka version 2.2.2:

. So this PR just updates the version string => Sarama version mapping in the code to reflect this.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2020
@ycombinator ycombinator added the Team:Services (Deprecated) Label for the former Integrations-Services team label Oct 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2020
@ycombinator ycombinator added libbeat needs_reviewer PR needs to be assigned a reviewer labels Oct 30, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 30, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22328 updated]

  • Start Time: 2020-10-30T19:07:35.882+0000

  • Duration: 66 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 16380
Skipped 1344
Total 17724

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16380
Skipped 1344
Total 17724

@ycombinator ycombinator merged commit 89f38cd into elastic:master Nov 2, 2020
@ycombinator ycombinator deleted the add-kafka-2.2 branch November 2, 2020 12:11
ycombinator added a commit to ycombinator/beats that referenced this pull request Nov 2, 2020
* Adding Kafka version 2.2

* Adding CHANGELOG entry
ycombinator added a commit to ycombinator/beats that referenced this pull request Nov 2, 2020
* Adding Kafka version 2.2

* Adding CHANGELOG entry
ycombinator added a commit that referenced this pull request Nov 3, 2020
* Adding Kafka version 2.2

* Adding CHANGELOG entry
ycombinator added a commit that referenced this pull request Nov 3, 2020
* Adding Kafka version 2.2 (#22328)

* Adding Kafka version 2.2

* Adding CHANGELOG entry

* Fixing CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libbeat needs_reviewer PR needs to be assigned a reviewer Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants