Add cgroup metrics to system/process MetricSet #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds metrics from the cpu, cpuacct, memory, and blkio cgroup subsystems. Cgroup metrics are not reported for processes that are members of the default cgroup ('/').
andrewkroh
force-pushed
the
feature/mb/process-cgroup
branch
from
84cc0a0
to
18d7004
Compare
| Path to the cgroup relative to the cgroup subsystem's | ||
| mountpoint. | ||
|
|
||
| - name: cfs.period.us |
There was a problem hiding this comment.
We should add this to our conventions: us = microseconds
|
LGTM. I left some comments related to naming of the fields but I think that is something we can also improve up in at a later stage. |
|
@andrewkroh One thing I realised now looking at the code again is if we should add a config option "cgroup" to only enable the cgroup fields if it is set to true? WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds metrics from the cpu, cpuacct, memory, and blkio cgroup subsystems. Cgroup metrics are not reported for processes that are members of the default cgroup ('/').