Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20779 to 7.x: [Elastic Agent] Rename *ConfigChange to PolicyChange #21390

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #20779 to 7.x branch. Original message:

This rename the ConfigChange to PolicyChange for:

  • The internal type for the actions.
  • The handler
  • The introspections

This depends on change on Kibana to return the new Type and the new
"Policy" key.

The kibana API need to be adjusted to send the right action type and the right fields.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

[Elastic Agent] Rename *ConfigChange to PolicyChange (elastic#20779)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
@michalpristas michalpristas added Team:Ingest Management Ingest Management:beta2 Group issues for ingest management beta2 labels Sep 29, 2020
@michalpristas michalpristas self-assigned this Sep 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 29, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21390 updated]

  • Start Time: 2020-09-30T08:56:53.161+0000

  • Duration: 35 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 1390
Skipped 4
Total 1394

@michalpristas michalpristas merged commit bb7f0e7 into elastic:7.x Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Ingest Management:beta2 Group issues for ingest management beta2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants