Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mark flaky tests #21300

Merged
merged 5 commits into from
Sep 30, 2020
Merged

fix: mark flaky tests #21300

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
becca8d
fix: mark flaky test
kuisathaverat Sep 24, 2020
7864a40
Apply suggestions from code review
kuisathaverat Sep 24, 2020
b32bc8e
Update libbeat/outputs/elasticsearch/client_integration_test.go
kuisathaverat Sep 29, 2020
eb093d8
Apply suggestions from code review
kuisathaverat Sep 29, 2020
ad2a4fb
Apply suggestions from code review
kuisathaverat Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions auditbeat/module/file_integrity/eventreader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func init() {
const ErrorSharingViolation syscall.Errno = 32

func TestEventReader(t *testing.T) {
t.Skip("Flaky test: about 1/10 of bulds fails https://github.com/elastic/beats/issues/21302")
// Make dir to monitor.
dir, err := ioutil.TempDir("", "audit")
if err != nil {
Expand Down Expand Up @@ -240,6 +241,7 @@ func TestEventReader(t *testing.T) {
}

func TestRaces(t *testing.T) {
t.Skip("Flaky test: about 1/20 of bulds fails https://github.com/elastic/beats/issues/21303")
const (
fileMode os.FileMode = 0640
N = 100
Expand Down
5 changes: 5 additions & 0 deletions filebeat/tests/system/test_autodiscover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import docker
import filebeat
import os
import pytest
kuisathaverat marked this conversation as resolved.
Show resolved Hide resolved
import unittest

from beat.beat import INTEGRATION_TESTS
Expand All @@ -11,6 +12,8 @@ class TestAutodiscover(filebeat.BaseTest):
"""
Test filebeat autodiscover
"""
# 1/20 build fails https://github.com/elastic/beats/issues/21305
@pytest.mark.flaky(reruns=1, reruns_delay=10)
kuisathaverat marked this conversation as resolved.
Show resolved Hide resolved
kuisathaverat marked this conversation as resolved.
Show resolved Hide resolved
@unittest.skipIf(not INTEGRATION_TESTS or
os.getenv("TESTING_ENVIRONMENT") == "2x",
"integration test not available on 2.x")
Expand Down Expand Up @@ -42,6 +45,8 @@ def test_docker(self):
self.wait_until(lambda: self.log_contains('Stopping runner: input'))
proc.check_kill_and_wait()

# 16/20 build fails https://github.com/elastic/beats/issues/21306
@pytest.mark.flaky(reruns=16, reruns_delay=10)
kuisathaverat marked this conversation as resolved.
Show resolved Hide resolved
@unittest.skipIf(not INTEGRATION_TESTS or
os.getenv("TESTING_ENVIRONMENT") == "2x",
"integration test not available on 2.x")
Expand Down
3 changes: 3 additions & 0 deletions filebeat/tests/system/test_reload_inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import pytest
import time
from filebeat import BaseTest

Expand Down Expand Up @@ -249,6 +250,8 @@ def test_load_configs(self):
assert output[0]["message"] == first_line
assert output[1]["message"] == second_line

# 1/20 build fails https://github.com/elastic/beats/issues/21307
@pytest.mark.flaky(reruns=1, reruns_delay=10)
def test_reload_same_config(self):
"""
Test reload same config with same file but different config. Makes sure reloading also works on conflicts.
Expand Down
3 changes: 3 additions & 0 deletions x-pack/auditbeat/tests/system/test_metricsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import jinja2
import os
import platform
import pytest
import sys
import time
import unittest
Expand Down Expand Up @@ -42,6 +43,8 @@ def test_metricset_login(self):
# Metricset is beta and that generates a warning, TODO: remove later
self.check_metricset("system", "login", COMMON_FIELDS + fields, config, warnings_allowed=True)

# 1/20 build fails https://github.com/elastic/beats/issues/21308
@pytest.mark.flaky(reruns=1, reruns_delay=10)
@unittest.skipIf(sys.platform == "win32", "Not implemented for Windows")
@unittest.skipIf(sys.platform.startswith('linux') and not (os.path.isdir("/var/lib/dpkg") or os.path.isdir("/var/lib/rpm")),
"Only implemented for dpkg and rpm")
Expand Down