Configurable Elasticsearch index pattern #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I think this will require some changes in docs & changelog. |
urso
force-pushed
the
enh/es-index-config
branch
from
f1d6788
to
6acacda
Compare
|
Yes, requires updates to docs. With change being quite complex and format strings being new I'd like to add some doc on config file format and supported 'types' in config file first. For example: |
urso
force-pushed
the
enh/es-index-config
branch
from
6acacda
to
11056ae
Compare
5 tasks
|
Should we change as part of this also our default config file? https://github.com/elastic/beats/blob/master/filebeat/filebeat.full.yml#L337 What I have in mind is that if someone upgrades to 5.0 the default in the config file is still the same as before. Also uncommenting should have the same affect as the default we use. |
|
@ruflin my bad working on too many branches in parallel. Default config should be updated in this PR. |
Update elasticsearch index configuration to support format strings to fully
configure the index names to be used.
The default index is `<beatname>-%{+yyyy.MM.dd}` basically mimicing the old
behavior of `output.elasticsearch.index`.
More complex index selection rules can be configured via
`output.elasticsearch.indices`. Implementation is based on outil.Select
support.
urso
force-pushed
the
enh/es-index-config
branch
from
11056ae
to
373a978
Compare
|
full config files have been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2074
Depends on #2118
Implement index selector based on selector support provided by #2087 and new format string support.
Default index pattern changes to
beatname-%{+yyyy.MM.dd}.More advanced index selection via selector:
If
output.elasticsearch.indicesdoesn't match, default case inoutput.elasticsearch.indexis used (which is always set to default value on init).Rules are similar to #2064 with supported keywords:
index,default,mapping,when.