Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update a scenario when ca is self signed. #21090

Merged
merged 2 commits into from
Oct 27, 2020
Merged

update a scenario when ca is self signed. #21090

merged 2 commits into from
Oct 27, 2020

Conversation

Camilleli
Copy link
Contributor

@Camilleli Camilleli commented Sep 15, 2020

reference

What does this PR do?

Why is it important?

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 15, 2020
@Camilleli Camilleli added Team:Docs Label for the Observability docs team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 15, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21090 updated]

  • Start Time: 2020-10-27T16:48:54.078+0000

  • Duration: 25 min 57 sec

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I have a grammar suggestion. Once fixed, I can take care of merging and cherry-picking.

libbeat/docs/shared-ssl-config.asciidoc Outdated Show resolved Hide resolved
@botelastic
Copy link

botelastic bot commented Oct 21, 2020

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added Stalled and removed Stalled labels Oct 21, 2020
@bmorelli25 bmorelli25 self-assigned this Oct 27, 2020
@bmorelli25 bmorelli25 merged commit a46a0ae into 7.9 Oct 27, 2020
@bmorelli25 bmorelli25 deleted the Camilleli-patch-1 branch October 27, 2020 17:14
bmorelli25 pushed a commit to bmorelli25/beats that referenced this pull request Oct 27, 2020
* update a scenario when ca is self signed.

[reference](stripe/stripe-go#1003 (comment))

* Update libbeat/docs/shared-ssl-config.asciidoc

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
# Conflicts:
#	libbeat/docs/shared-ssl-config.asciidoc
bmorelli25 added a commit that referenced this pull request Nov 3, 2020
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Camille Li <camille.li@elastic.co>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* update a scenario when ca is self signed.

[reference](stripe/stripe-go#1003 (comment))

* Update libbeat/docs/shared-ssl-config.asciidoc

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants