Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a default for failure_cache.min_ttl #21085

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Adds a default for failure_cache.min_ttl #21085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e6015
Adds a default for failure_cache.min_ttl
ycombinator Sep 14, 2020
c7e967b
Parse YAML as inline + fix default value
ycombinator Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libbeat/processors/dns/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (

// Config defines the configuration options for the DNS processor.
type Config struct {
CacheConfig
CacheConfig `config:",inline"`
Nameservers []string `config:"nameservers"` // Required on Windows. /etc/resolv.conf is used if none are given.
Timeout time.Duration `conifg:"timeout"` // Per request timeout (with 2 nameservers the total timeout would be 2x).
Type string `config:"type" validate:"required"` // Reverse is the only supported type currently.
Expand Down Expand Up @@ -89,7 +89,7 @@ type CacheSettings struct {
TTL time.Duration `config:"ttl"`

// Minimum TTL value for successful DNS responses.
MinTTL time.Duration `config:"min_ttl" validate:"min=1"`
MinTTL time.Duration `config:"min_ttl" validate:"min=1ns"`

// Initial capacity. How much space is allocated at initialization.
InitialCapacity int `config:"capacity.initial" validate:"min=0"`
Expand Down Expand Up @@ -166,6 +166,7 @@ var defaultConfig = Config{
MaxCapacity: 10000,
},
FailureCache: CacheSettings{
MinTTL: time.Minute,
TTL: time.Minute,
InitialCapacity: 1000,
MaxCapacity: 10000,
Expand Down