Renamed redis.index option to redis.key #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
tsg
force-pushed
the
replace_redis_index_with_key
branch
from
df4cb16
to
245dd0a
Compare
|
LGTM. missing change in config.full.yml (in libbeat) plus |
Closed
The "index" setting name has historical reasons, from the times that all outputs shared the same configuration options. Since the meaning and contents of the "index" setting are starting to vary per output, it's time to clean this up. The Redis "index" is now called "key". Before this change, the index was still somehow special, since it was set to the beatName outside of the output. This removes this hack, and sets index to beatName only in the Elasticsearch and Logstash modules. This also removes the `index` setting for the file output, but that was never documented. Part of elastic#2074.
tsg
force-pushed
the
replace_redis_index_with_key
branch
from
245dd0a
to
e83d6a1
Compare
|
@urso Thanks for the review. Configs updated and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "index" setting name has historical reasons, from the times that
all outputs shared the same configuration options. Since the meaning and
contents of the "index" setting are starting to vary per output, it's time
to clean this up. The Redis "index" is now called "key".
The "index" setting still works, but it's deprecated.
Before this change, the index was still somehow special, since it was set to
the beatName outside of the output. This removes this hack, and sets index to
beatName only in the Elasticsearch and Logstash modules.
Part of #2074.
This also removes the
output.file.indexsetting, but this setting was never documented, so removing it shouldn't affect anyone. The setting was equivalent to settingoutput.file.filename.