Check if Filebeat log harvester tries to open named pipe #20450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
[zube]: In Review
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
urso
approved these changes
Aug 6, 2020
kvch
force-pushed
the
fix-filebeat-hang-on-fifo
branch
from
9bc4d0b
to
91e6e37
Compare
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
## What does this PR do? This PR adds a check before opening a file for harvester Filebeat. If the file is a named pipe, an error is returned and the file is not opened. ## Why is it important? Previously if someone wanted to open a named pipe without a writer, Filebeat hangs. ## Related issues Closes elastic#18682
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 4, 2020
## What does this PR do? This PR adds a check before opening a file for harvester Filebeat. If the file is a named pipe, an error is returned and the file is not opened. ## Why is it important? Previously if someone wanted to open a named pipe without a writer, Filebeat hangs. ## Related issues Closes elastic#18682 (cherry picked from commit a89d81f)
4 tasks
kvch
added
v7.11.0
and removed
needs_backport
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 4, 2020
## What does this PR do? This PR adds a check before opening a file for harvester Filebeat. If the file is a named pipe, an error is returned and the file is not opened. ## Why is it important? Previously if someone wanted to open a named pipe without a writer, Filebeat hangs. ## Related issues Closes elastic#18682 (cherry picked from commit a89d81f)
4 tasks
kvch
added a commit
that referenced
this pull request
Nov 6, 2020
…2422) ## What does this PR do? This PR adds a check before opening a file for harvester Filebeat. If the file is a named pipe, an error is returned and the file is not opened. ## Why is it important? Previously if someone wanted to open a named pipe without a writer, Filebeat hangs. ## Related issues Closes #18682 (cherry picked from commit a89d81f)
kvch
added a commit
that referenced
this pull request
Nov 6, 2020
…2423) ## What does this PR do? This PR adds a check before opening a file for harvester Filebeat. If the file is a named pipe, an error is returned and the file is not opened. ## Why is it important? Previously if someone wanted to open a named pipe without a writer, Filebeat hangs. ## Related issues Closes #18682 (cherry picked from commit a89d81f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a check before opening a file for harvester Filebeat. If the file is a named pipe, an error is returned and the file is not opened.
Why is it important?
Previously if someone wanted to open a named pipe without a writer, Filebeat hangs.
Checklist
- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #18682