Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Updates to Suricata module #20220

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

andrewkroh
Copy link
Member

What does this PR do?

This makes a few miscellaneous changes to the Suricata module to cleanup dashboards and fix a few minor issues in the pipeline.

  • Fix convert processor fail_on_error parameter naming.
  • Add event.ingested to ingest node pipeline.
  • Remove ECS suffixing from dashboard/viz titles.
  • Prioritize using ECS fields in dashboards.
  • Add Suricata logo to dashboards.

Checklist

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

filebeat-suricata-alerts
filebeat-suricata-events

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 23, 2020
- Fix convert processor fail_on_error parameter naming.
- Add event.ingested to ingest node pipeline.
- Remove ECS suffixing from dashboard/viz titles.
- Prioritize using ECS fields in dashboards.
- Add Suricata logo to dashboards.
@andrewkroh andrewkroh marked this pull request as ready for review July 23, 2020 22:03
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 23, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20220 updated]

  • Start Time: 2020-07-28T20:53:50.679+0000

  • Duration: 51 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 5508
Skipped 828
Total 6336

@andrewkroh
Copy link
Member Author

Looks like I need to update test_module.py to ignore event.ingested.

@andrewkroh andrewkroh merged commit 0659a12 into elastic:master Jul 29, 2020
v1v added a commit to v1v/beats that referenced this pull request Jul 30, 2020
…ne-2.0

* upstream/master: (29 commits)
  Add an explicit system test for processes on unix systems (elastic#20320)
  [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks (elastic#20305)
  [CI] Update README.md with CI references (elastic#20316)
  Add ECK doc links to Heartbeat docs (elastic#20284)
  [Filebeat] Add export tests to x-pack/filebeat (elastic#20156)
  feat(ci): support building docker images for PRs (elastic#20323)
  Update system tests dependency (elastic#20287)
  [Libbeat] Log debug message if the Kibana dashboard can not be imported from the archive (elastic#12211) (elastic#20150)
  [Filebeat][Gsuite] Transform all dates to timestamp with processor (elastic#20308)
  Infer types in Prometheus remote_write (elastic#19944)
  Remove unnecessary restarts of metricsets while using Node autodiscover (elastic#19974)
  docs: update changelog on master branch (elastic#20259)
  feat(ci): support storing artifacts for PRs in separate dirs (elastic#20282)
  [CI] Change upstream reference (elastic#20296)
  [Filebeat] Updates to Suricata module (elastic#20220)
  [docs] Fix Windows download link for agent (elastic#20258)
  [docs] Rename release highlights to what's new (elastic#20255)
  fix: update the display name of the multibranch job (elastic#20265)
  [Elastic Agent] Add basic protocol to control Elastic Agent. (elastic#20146)
  Cisco ASA: Fix message 106100 (elastic#20245)
  ...
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 3, 2020
This is a followup to elastic#20220 to get the correct dashboard files into place.
andrewkroh added a commit that referenced this pull request Aug 3, 2020
This is a followup to #20220 to get the correct dashboard files into place.
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 6, 2020
* Updates to Suricata module

- Fix convert processor fail_on_error parameter naming.
- Add event.ingested to ingest node pipeline.
- Remove ECS suffixing from dashboard/viz titles.
- Prioritize using ECS fields in dashboards.
- Add Suricata logo to dashboards.

* Always remove event.ingested from test data

(cherry picked from commit 0659a12)
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 6, 2020
This is a followup to elastic#20220 to get the correct dashboard files into place.

(cherry picked from commit b671339)
andrewkroh added a commit that referenced this pull request Aug 11, 2020
)

* [Filebeat] Updates to Suricata module (#20220)

* Updates to Suricata module

- Fix convert processor fail_on_error parameter naming.
- Add event.ingested to ingest node pipeline.
- Remove ECS suffixing from dashboard/viz titles.
- Prioritize using ECS fields in dashboards.
- Add Suricata logo to dashboards.

* Always remove event.ingested from test data

(cherry picked from commit 0659a12)

* Update Suricata dashboards (#20394)

This is a followup to #20220 to get the correct dashboard files into place.

(cherry picked from commit b671339)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
* Updates to Suricata module

- Fix convert processor fail_on_error parameter naming.
- Add event.ingested to ingest node pipeline.
- Remove ECS suffixing from dashboard/viz titles.
- Prioritize using ECS fields in dashboards.
- Add Suricata logo to dashboards.

* Always remove event.ingested from test data
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
This is a followup to elastic#20220 to get the correct dashboard files into place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants