Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Fixed unzip on older windows #20088

Merged
merged 3 commits into from
Jul 21, 2020
Merged

[Ingest Manager] Fixed unzip on older windows #20088

merged 3 commits into from
Jul 21, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Jul 21, 2020 •
edited
Loading

What does this PR do?

We used Expand_Archive function provided by powershell to unpack zip archives on windows. this is not available on PowerShell 4. Strategy is changed not to use powershell functionaliry but rather the approach taken with tars - walking and expanding the archive.

Why is it important?

Supporting windows 8 and server 2012

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug review needs_backport PR is waiting to be backported to other branches. Team:Ingest Management Ingest Management:beta1 Group issues for ingest management beta1 labels Jul 21, 2020
@michalpristas michalpristas self-assigned this Jul 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 21, 2020
@michalpristas michalpristas mentioned this pull request Jul 21, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 21, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20088 updated]

  • Start Time: 2020-07-21T11:09:33.316+0000

  • Duration: 29 min 17 sec

blakerouse
blakerouse approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ph
Copy link
Contributor

ph commented Jul 21, 2020

@michalpristas going to merge this and create a backport so we have it on the next BC.

@ph ph merged commit ded2e99 into elastic:master Jul 21, 2020
@ph ph mentioned this pull request Jul 21, 2020
Merged
6 tasks
@ph ph removed the needs_backport PR is waiting to be backported to other branches. label Jul 21, 2020
ph pushed a commit to ph/beats that referenced this pull request Jul 21, 2020
@michalpristas @ph
[Ingest Manager] Fixed unzip on older windows (elastic#20088)
8bf7c63 
* unpacking using zip package

* changelog

* fmt

(cherry picked from commit ded2e99)
@ph ph added the v7.10.0 label Jul 21, 2020
@ph ph mentioned this pull request Jul 21, 2020
Merged
6 tasks
ph pushed a commit to ph/beats that referenced this pull request Jul 21, 2020
@michalpristas @ph
[Ingest Manager] Fixed unzip on older windows (elastic#20088)
b02fb03 
* unpacking using zip package

* changelog

* fmt

(cherry picked from commit ded2e99)
@ph ph added the v7.9.0 label Jul 21, 2020
@michalpristas
Copy link
Contributor Author

thanks @ph

michalpristas added a commit to michalpristas/beats that referenced this pull request Jul 23, 2020
@michalpristas
[Ingest Manager] Fixed unzip on older windows (elastic#20088)
b2a6504 
* unpacking using zip package

* changelog

* fmt
michalpristas added a commit to michalpristas/beats that referenced this pull request Jul 23, 2020
@michalpristas
[Ingest Manager] Fixed unzip on older windows (elastic#20088)
22f3c32 
* unpacking using zip package

* changelog

* fmt
ph added a commit that referenced this pull request Jul 27, 2020
@ph @michalpristas
[Ingest Manager] Fixed unzip on older windows (#20088) (#20109)
702d5bf 
* unpacking using zip package

* changelog

* fmt

(cherry picked from commit ded2e99)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
ph added a commit that referenced this pull request Jul 27, 2020
@ph @michalpristas
[Ingest Manager] Fixed unzip on older windows (#20088) (#20108)
cbfbc43 
* unpacking using zip package

* changelog

* fmt

(cherry picked from commit ded2e99)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
v1v added a commit to v1v/beats that referenced this pull request Jul 29, 2020
@v1v
Merge remote-tracking branch 'upstream/7.9' into backport/7.9/pr-19960
59a6124 
* upstream/7.9: (32 commits)
  feat(ci): support storing artifacts for PRs in separate dirs (elastic#20282) (elastic#20301)
  Cisco ASA: Fix message 106100 (elastic#20245) (elastic#20277)
  [CI] Change upstream reference (elastic#20296) (elastic#20297)
  [docs] Fix Windows download link for agent (elastic#20258) (elastic#20290)
  Cherry-pick to 7.9: [docs] Rename release highlights to what's new (elastic#20255) (elastic#20285)
  Elastic agent on k8s (elastic#19727) (elastic#20262)
  [Filebeat Module] Defender ATP - Adding dashboard (elastic#20058) (elastic#20093)
  fix: use a fixed worker type for tests (elastic#20130) (elastic#20247)
  [Elastic Agent] Fix Windows powershell install service script (elastic#20203) (elastic#20252)
  [Ingest Manager] Fixed unzip on older windows  (elastic#20088) (elastic#20109)
  adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232) (elastic#20237)
  [Filebeat][Gsuite] Make GSuite docs more clear (elastic#19981) (elastic#20067)
  Increase index.max_docvalue_fields_search to 200 (elastic#20218) (elastic#20221)
  Call host parser only once when building light metricsets (elastic#20149) (elastic#20190)
  [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191) (elastic#20212)
  [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207) (elastic#20217)
  [libbeat] Fix write error in ensureWriter.Write (elastic#20112) (elastic#20145)
  Cherry-pick elastic#20127 to 7.9: Fix failing unit tests on windows  (elastic#20180)
  Remove f5/firepass rsa2elk fileset (elastic#20160) (elastic#20206)
  Cherry-pick elastic#20138 to 7.9: [Filebeat] Update crowdstrike module (elastic#20177)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@michalpristas @melchiormoulin
[Ingest Manager] Fixed unzip on older windows (elastic#20088)
8614fa7 
* unpacking using zip package

* changelog

* fmt
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ph @michalpristas
[Ingest Manager] Fixed unzip on older windows (elastic#20088) (elasti…
fe0cc33 
…c#20109)

* unpacking using zip package

* changelog

* fmt

(cherry picked from commit 54ef816)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
bug Ingest Management:beta1 Group issues for ingest management beta1 review v7.9.0 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalpristas @elasticmachine @ph @blakerouse