[Filebeat][Gsuite] Make GSuite docs more clear #19981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
marc-gr
force-pushed
the
gsuite-better-docs
branch
from
3aebc2b
to
9b6a946
Compare
jamiehynds
reviewed
Jul 16, 2020
| - https://developers.google.com/admin-sdk/reports/v1/appendix/activity/admin-application-settings[Admin Audit Activity Events] | ||
| - https://developers.google.com/admin-sdk/reports/v1/appendix/activity/drive[Drive Activity Events] | ||
| - https://developers.google.com/admin-sdk/reports/v1/appendix/activity/groups[Groups Audit Activity Events] | ||
| - SAML Audit Activity Events https://developers.google.com/admin-sdk/reports/v1/appendix/activity/saml[api docs] https://support.google.com/a/answer/7007375?hl=en&ref_topic=9027054[help]: View users’ successful and failed sign-ins to SAML applications. |
There was a problem hiding this comment.
@marc-gr The content looks good, but could we use a table instead of a list? As the list of GSuite event logs grows, a table will be a much cleaner layout.
marc-gr
force-pushed
the
gsuite-better-docs
branch
2 times, most recently
from
a9fb98d
to
0c43a86
Compare
andrewkroh
reviewed
Jul 16, 2020
marc-gr
force-pushed
the
gsuite-better-docs
branch
from
0c43a86
to
2ad94f7
Compare
marc-gr
force-pushed
the
gsuite-better-docs
branch
from
2ad94f7
to
cc1d5d0
Compare
jamiehynds
approved these changes
Jul 20, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
2 tasks
2 tasks
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Jul 27, 2020
* Make GSuite docs more clear * Add links to help and summary * Convert filesets info to a table (cherry picked from commit f74745b)
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Jul 27, 2020
* Make GSuite docs more clear * Add links to help and summary * Convert filesets info to a table (cherry picked from commit f74745b)
marc-gr
added a commit
that referenced
this pull request
Jul 27, 2020
marc-gr
added a commit
that referenced
this pull request
Jul 27, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 29, 2020
* upstream/7.9: (32 commits) feat(ci): support storing artifacts for PRs in separate dirs (elastic#20282) (elastic#20301) Cisco ASA: Fix message 106100 (elastic#20245) (elastic#20277) [CI] Change upstream reference (elastic#20296) (elastic#20297) [docs] Fix Windows download link for agent (elastic#20258) (elastic#20290) Cherry-pick to 7.9: [docs] Rename release highlights to what's new (elastic#20255) (elastic#20285) Elastic agent on k8s (elastic#19727) (elastic#20262) [Filebeat Module] Defender ATP - Adding dashboard (elastic#20058) (elastic#20093) fix: use a fixed worker type for tests (elastic#20130) (elastic#20247) [Elastic Agent] Fix Windows powershell install service script (elastic#20203) (elastic#20252) [Ingest Manager] Fixed unzip on older windows (elastic#20088) (elastic#20109) adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232) (elastic#20237) [Filebeat][Gsuite] Make GSuite docs more clear (elastic#19981) (elastic#20067) Increase index.max_docvalue_fields_search to 200 (elastic#20218) (elastic#20221) Call host parser only once when building light metricsets (elastic#20149) (elastic#20190) [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191) (elastic#20212) [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207) (elastic#20217) [libbeat] Fix write error in ensureWriter.Write (elastic#20112) (elastic#20145) Cherry-pick elastic#20127 to 7.9: Fix failing unit tests on windows (elastic#20180) Remove f5/firepass rsa2elk fileset (elastic#20160) (elastic#20206) Cherry-pick elastic#20138 to 7.9: [Filebeat] Update crowdstrike module (elastic#20177) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Make GSuite docs more clear * Add links to help and summary * Convert filesets info to a table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After reading Gsuite docs for 7.9 I thought some things might benefit of a bit more info.
Why is it important?
Docs need to be as clear as possible for people who sets up the module.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.