Cherry-pick #18655 to 7.x: Remove vendor folder from the repository #19477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To update or add a dependency use the standard tools provided by Golang. (cherry picked from commit 5426df0)
kvch
added
[zube]: In Review
backport
Team:Services
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
michalpristas
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18655 to 7.x branch. Original message:
What does this PR do?
This PR removes the vendor folder from the repository.
go.elastic.co/go-licence-detectorto generate NOTICE file- [ ] use package proxy/mirror when running CI jobs and also to use it locally if neededthe generated Beats use vendor folder, but users are free to move away from it
By removing the folder we become vulnerable to new dangers:
To combat these we are adopting Artifactory and mirroring these modules to our own infra. Before we merge this PR we need to make sure we are prepared to mitigate these issues. So a working Artifactory mirror is a must-have beforehand.We decided to merge this without Artifactory. APM team had no issues with building their binaries consistently without an own package mirror, so we are positive this decision won't have a big impact on our builds.
To update dependencies, use the standard tools provided by Golang:
Why is it important?
We need to remove dependencies, as we are not allowed to vendor every dependency we use.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.