Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input v2 stateless manager #19406

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Conversation

urso
Copy link

@urso urso commented Jun 25, 2020

  • Enhancement

What does this PR do?

This change introduced an InputManager for stateless inputs, that do not
require end-to-end ACK or or state stored between restarts

The current state of the full implementation can be seen here and sample inputs based on the new API.

The full list of changes will include:

Test coverage report:

gocov test ./... | gocov report
ok  	github.com/elastic/beats/v7/filebeat/input/v2/input-stateless	0.008s	coverage: 72.2% of statements

github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 configuredInput.Run	 100.00% (6/6)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 NewInputManager	 100.00% (1/1)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 InputManager.Create	 75.00% (3/4)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 @76:8			 75.00% (3/4)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 InputManager.Init	 0.00% (0/1)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 configuredInput.Name	 0.00% (0/1)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 configuredInput.Test	 0.00% (0/1)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless			 --------------------	 72.22% (13/18)

Why is it important?

Filebeat input v2 API support

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@urso urso added review Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Project:Filebeat-Input-v2 Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 labels Jun 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 25, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 25, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [urso commented: jenkins run the tests please]

  • Start Time: 2020-06-30T13:44:22.181+0000

  • Duration: 27 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 543
Skipped 127
Total 670

urso added 2 commits June 30, 2020 13:07
This change introduced an InputManager for stateless inputs, that do not
require end-to-end ACK or or state stored between restarts.
@urso urso force-pushed the input-v2-stateless-manager branch from 3e08704 to e80b27e Compare June 30, 2020 11:08
@urso urso removed the blocked label Jun 30, 2020
@urso
Copy link
Author

urso commented Jun 30, 2020

jenkins run the tests please

@urso urso merged commit e689fd1 into elastic:master Jun 30, 2020
@urso urso deleted the input-v2-stateless-manager branch June 30, 2020 14:20
v1v added a commit to v1v/beats that referenced this pull request Jul 2, 2020
…ne-beats

* upstream/master: (105 commits)
  ci: enable packaging job (elastic#19536)
  ci: disable upstream trigger on PRs for the packaging job (elastic#19490)
  Implement memlog on-disk handling (elastic#19408)
  fix go.mod for PR elastic#19423 (elastic#19521)
  [MetricBeat] add param `aws_partition` to support aws-cn, aws-us-gov regions (elastic#19423)
  Input v2 stateless manager (elastic#19406)
  Input v2 compatibility layer (elastic#19401)
  [Elastic Agent] Fix artifact downloading to allow endpoint-security to be downloaded (elastic#19503)
  fix: ignore target changes on scans (elastic#19510)
  Add more helpers to pipeline/testing package (elastic#19405)
  Report dependencies in CSV format (elastic#19506)
  [Filebeat] Fix reference leak in TCP and Unix socket inputs (elastic#19459)
  Cursor input skeleton (elastic#19378)
  Add changelog. (elastic#19495)
  [DOC] Typo in Kerberos (elastic#19265)
  Remove accidentally commited unused NOTICE template (elastic#19485)
  [Elastic Agent] Support the install, control, and uninstall of Endpoint (elastic#19248)
  [Filebeat][httpjson] Add split_events_by config setting (elastic#19246)
  ci: disabling packaging job until we fix it (elastic#19481)
  Fix golang.org/x/tools to release1.13 (elastic#19478)
  ...
urso pushed a commit to urso/beats that referenced this pull request Jul 8, 2020
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Jul 8, 2020
urso pushed a commit that referenced this pull request Jul 8, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat Project:Filebeat-Input-v2 review skip-test-plan Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants