Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on vsphere module #19078

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Fix crash on vsphere module #19078

merged 2 commits into from
Jun 10, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jun 9, 2020

Host information is not always available, when it is not, some structures
are nil references. Avoid using them to retrieve additional information.

Fixes #18996.

@jsoriano jsoriano added bug review needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Platforms Label for the Integrations - Platforms team v7.6.3 v7.9.0 v7.8.1 v7.7.2 labels Jun 9, 2020
@jsoriano jsoriano requested a review from adriansr June 9, 2020 15:39
@jsoriano jsoriano self-assigned this Jun 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 9, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 9, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19078 updated]

  • Start Time: 2020-06-09T15:49:11.635+0000

  • Duration: 82 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 3658
Skipped 829
Total 4487

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-09T17:05:01.506+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-09T17:08:03.361+0000

    • log

@jsoriano jsoriano merged commit 827f25a into elastic:master Jun 10, 2020
@jsoriano jsoriano deleted the vsphere-host-panic branch June 10, 2020 10:53
@jsoriano jsoriano mentioned this pull request Jun 10, 2020
Merged
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Jun 10, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Jun 10, 2020
@jsoriano
Fix crash on vsphere module (elastic#19078)
8c6bc80 
(cherry picked from commit 827f25a)
@jsoriano jsoriano mentioned this pull request Jun 10, 2020
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Jun 10, 2020
@jsoriano
Fix crash on vsphere module (elastic#19078)
16fd3af 
(cherry picked from commit 827f25a)
@jsoriano jsoriano mentioned this pull request Jun 10, 2020
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Jun 10, 2020
@jsoriano
Fix crash on vsphere module (elastic#19078)
e13d310 
(cherry picked from commit 827f25a)
@jsoriano jsoriano mentioned this pull request Jun 10, 2020
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Jun 10, 2020
@jsoriano
Fix crash on vsphere module (elastic#19078)
3d28e58 
(cherry picked from commit 827f25a)
@jsoriano jsoriano mentioned this pull request Jun 10, 2020
Merged
jsoriano added a commit that referenced this pull request Jun 11, 2020
@jsoriano
Fix crash on vsphere module (#19078) (#19096)
4a7bf61 
Host information is not always available, when it is not, some structures
are nil references. Avoid using them to retrieve additional information.

(cherry picked from commit 827f25a)
jsoriano added a commit that referenced this pull request Jun 11, 2020
@jsoriano
Fix crash on vsphere module (#19078) (#19097)
9fac0aa 
Host information is not always available, when it is not, some structures
are nil references. Avoid using them to retrieve additional information.

(cherry picked from commit 827f25a)
jsoriano added a commit that referenced this pull request Jun 11, 2020
@jsoriano
Fix crash on vsphere module (#19078) (#19098)
022f770 
Host information is not always available, when it is not, some structures
are nil references. Avoid using them to retrieve additional information.

(cherry picked from commit 827f25a)
jsoriano added a commit that referenced this pull request Jun 11, 2020
@jsoriano
Fix crash on vsphere module (#19078) (#19099)
d425058 
Host information is not always available, when it is not, some structures
are nil references. Avoid using them to retrieve additional information.

(cherry picked from commit 827f25a)
v1v added a commit to v1v/beats that referenced this pull request Jun 12, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/fix-warni…
fd04fee 
…ngs-archive

* upstream/master: (119 commits)
  Update filebeat input docs (elastic#19110)
  Add ECS fields from log pipeline of PostgreSQL (elastic#19127)
  Init package libbeat/statestore (elastic#19117)
  [Ingest Manager] Retryable downloads of beats (elastic#19102)
  [DOCS] Add output.console to Functionbeat doc and Functionbeat reference file (elastic#18965)
  Add compatibility info (elastic#18929)
  Set ecszap version to v0.2.0 (elastic#19106)
  [filebeat][httpjson] Fix unit test function call (elastic#19124)
  [Filebeat][httpjson] Adds oauth2 support for httpjson input (elastic#18892)
  Allow host.* fields to be disabled in Suricata module (elastic#19107)
  Make selector string casing configurable (elastic#18854)
  Switch the GRPC communication where Agent is running the server and the beats are connecting back to Agent (elastic#18973)
  Disable host.* fields by default for netflow module (elastic#19087)
  Automatically fill zube teams on backports if available (elastic#18924)
  Fix crash on vsphere module (elastic#19078)
  [Ingest Manager] Download snapshot artifacts from snapshots repo (elastic#18685)
  [Ingest Manager] Basic Elastic Agent documentation (elastic#19030)
  Make user.id a string in system/users, in line with ECS (elastic#19019)
  [docs] Add 7.8 release highlights placeholder file (elastic#18493)
  Fix translate_sid's empty target field handling (elastic#18991)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@jsoriano @melchiormoulin
Fix crash on vsphere module (elastic#19078)
75d3389
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Fix crash on vsphere module (elastic#19078) (elastic#19098)
16baee3 
Host information is not always available, when it is not, some structures
are nil references. Avoid using them to retrieve additional information.

(cherry picked from commit 617279a)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Fix crash on vsphere module (elastic#19078) (elastic#19099)
78a76e7 
Host information is not always available, when it is not, some structures
are nil references. Avoid using them to retrieve additional information.

(cherry picked from commit 617279a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

Assignees

@jsoriano jsoriano

Labels
bug review Team:Platforms Label for the Integrations - Platforms team v7.6.3 v7.7.2 v7.8.0 v7.8.1 v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metricbeat vsphere/virtualmachine crash
4 participants
@jsoriano @elasticmachine @adriansr @andresrc