Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18985 to 7.x: Fix metricsets in gcp module to use new stackdriver config format #19024

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Cherry-pick #18985 to 7.x: Fix metricsets in gcp module to use new stackdriver config format #19024

merged 1 commit into from
Jun 12, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

Cherry-pick of PR #18985 to 7.x branch. Original message:

This is a followup PR for #18691 to fix all metricsets under googlecloud module to use new stackdriver config format.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 6, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 6, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Jun 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 6, 2020
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Maybe we should merge this already @ChrsMark

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed it :(

lgtm!

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user kaiyan-sheng, Replayed #1]

  • Start Time: 2020-06-12T12:26:09.251+0000

  • Duration: 53 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 497
Skipped 48
Total 545

@kaiyan-sheng
Copy link
Contributor Author

No problem 😄 Thank you @ChrsMark and @sayden !!

@kaiyan-sheng kaiyan-sheng merged commit bb503f8 into elastic:7.x Jun 12, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_18985_7.x branch June 12, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants