Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error message actionable #18667

Merged
merged 2 commits into from
May 21, 2020
Merged

Make error message actionable #18667

merged 2 commits into from
May 21, 2020

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

Makes the error message about a Beat's data path being locked actionable.

Why is it important?

Actionable error messages don't just explain the problem but also guide users towards possible solutions.

@ycombinator ycombinator added libbeat v8.0.0 Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 v7.8.1 labels May 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 20, 2020
@ycombinator ycombinator added [zube]: In Review needs_team Indicates that the issue/PR needs a Team:* label labels May 20, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2020
@ycombinator ycombinator added needs_backport PR is waiting to be backported to other branches. needs_team Indicates that the issue/PR needs a Team:* label labels May 20, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2020
@ycombinator ycombinator requested a review from urso May 20, 2020 18:49
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request Make error message actionable #18667 opened]

  • Reason: Aborted from #2

  • Start Time: 2020-05-20T18:48:48.662+0000

  • Duration: 67 min 19 sec (4039435)

  • Commit: d956a4a3da8115c2e70aed57bfb4c8d8297b2e2e

Test stats 🧪

Test Results
Failed 0
Passed 9190
Skipped 1542
Total 10732

Log output

Expand to view the last 100 lines of log output 

[2020-05-20T19:51:46.588Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-05-20T19:51:46.588Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-05-20T19:51:46.588Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-05-20T19:51:46.588Z] + FILE=journalbeat/build/coverage/full.cov
[2020-05-20T19:51:46.588Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-05-20T19:51:47.627Z] Failed in branch Metricbeat x-pack
[2020-05-20T19:54:38.688Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats
[2020-05-20T19:54:39.560Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-05-20T19:54:39.766Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Lint
[2020-05-20T19:54:42.059Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-05-20T19:54:44.162Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Winlogbeat-oss
[2020-05-20T19:54:46.315Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-05-20T19:54:48.973Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Dockerlogbeat
[2020-05-20T19:54:51.547Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Journalbeat-oss
[2020-05-20T19:54:54.204Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-05-20T19:54:56.446Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-05-20T19:54:58.237Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-05-20T19:54:59.237Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-05-20T19:55:00.345Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-05-20T19:55:01.503Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-05-20T19:55:02.879Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-05-20T19:55:04.134Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-05-20T19:55:05.355Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Heartbeat-oss
[2020-05-20T19:55:06.805Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-05-20T19:55:08.354Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Functionbeat-Mac-OS-X-x-pack
[2020-05-20T19:55:10.288Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Libbeat-x-pack
[2020-05-20T19:55:11.663Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-05-20T19:55:13.230Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Auditbeat-Linux
[2020-05-20T19:55:14.672Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Filebeat-Windows
[2020-05-20T19:55:15.890Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Heartbeat-Mac-OS-X
[2020-05-20T19:55:16.901Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-05-20T19:55:18.315Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-05-20T19:55:19.593Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Packetbeat-oss
[2020-05-20T19:55:20.434Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-05-20T19:55:21.679Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-Windows
[2020-05-20T19:55:23.034Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-05-20T19:55:24.293Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-05-20T19:55:25.366Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Filebeat-x-pack
[2020-05-20T19:55:26.608Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Auditbeat-Mac-OS-X
[2020-05-20T19:55:27.567Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Heartbeat-Windows
[2020-05-20T19:55:29.094Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Filebeat-oss
[2020-05-20T19:55:29.981Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Functionbeat-Windows
[2020-05-20T19:55:31.161Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Libbeat-oss
[2020-05-20T19:55:32.124Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-05-20T19:55:32.787Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-05-20T19:55:33.460Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Generators-Metricbeat-Mac-OS-X
[2020-05-20T19:55:34.101Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Auditbeat-Windows
[2020-05-20T19:55:34.844Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Libbeat-crosscompile
[2020-05-20T19:55:35.260Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Libbeat-stress-tests
[2020-05-20T19:55:35.674Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-05-20T19:55:36.777Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Generators-Beat-Mac-OS-X
[2020-05-20T19:55:37.744Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-05-20T19:55:38.923Z] + cat
[2020-05-20T19:55:38.923Z] + /usr/local/bin/runbld ./runbld-script
[2020-05-20T19:55:38.923Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-05-20T19:55:45.547Z] runbld>>> runbld started
[2020-05-20T19:55:45.547Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-05-20T19:55:46.972Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-18667' in order of occurrence in the config (last value wins).
[2020-05-20T19:55:48.368Z] runbld>>> Debug logging enabled.
[2020-05-20T19:55:48.368Z] runbld>>> Storing result
[2020-05-20T19:55:48.368Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-05-20T19:55:48.368Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200520195548-A041724E
[2020-05-20T19:55:48.368Z] runbld>>> Adding system facts.
[2020-05-20T19:55:49.318Z] runbld>>> Adding vcs info for the latest commit:  d956a4a3da8115c2e70aed57bfb4c8d8297b2e2e
[2020-05-20T19:55:49.583Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-05-20T19:55:49.584Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-05-20T19:55:49.584Z] Processing JUnit reports with runbld...
[2020-05-20T19:55:49.584Z] + echo 'Processing JUnit reports with runbld...'
[2020-05-20T19:55:50.157Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-05-20T19:55:50.157Z] runbld>>> DURATION: 12ms
[2020-05-20T19:55:50.157Z] runbld>>> STDOUT: 40 bytes
[2020-05-20T19:55:50.157Z] runbld>>> STDERR: 49 bytes
[2020-05-20T19:55:50.157Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-05-20T19:55:50.157Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats
[2020-05-20T19:55:51.611Z] runbld>>> Storing build metadata: 
[2020-05-20T19:55:51.611Z] runbld>>> Adding test report.
[2020-05-20T19:55:51.611Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats
[2020-05-20T19:55:52.581Z] runbld>>> Found 110 test output files
[2020-05-20T19:55:53.566Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-05-20T19:55:53.566Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-05-20T19:55:53.566Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-05-20T19:55:53.566Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-05-20T19:55:53.566Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-05-20T19:55:53.566Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-cloudfoundry.xml
[2020-05-20T19:55:54.144Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-05-20T19:55:54.407Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-05-20T19:55:54.984Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 10582 Skipped: 1304
[2020-05-20T19:55:54.984Z] runbld>>> Storing result
[2020-05-20T19:55:54.984Z] runbld>>> FAILURES: 0
[2020-05-20T19:55:55.246Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-05-20T19:55:55.246Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200520195548-A041724E
[2020-05-20T19:55:55.246Z] runbld>>> Email notification disabled by environment variable.
[2020-05-20T19:55:55.246Z] runbld>>> Slack notification disabled by environment variable.
[2020-05-20T19:56:03.137Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18667
[2020-05-20T19:56:04.752Z] [INFO] getVaultSecret: Getting secrets
[2020-05-20T19:56:05.151Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-20T19:56:08.499Z] + chmod 755 generate-build-data.sh
[2020-05-20T19:56:08.499Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18667/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18667/runs/1 ABORTED 4039435
[2020-05-20T19:56:09.050Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18667/runs/1/steps/?limit=10000 -o steps-info.json
[2020-05-20T19:56:15.533Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18667/runs/1/tests/?status=FAILED -o tests-errors.json

@ycombinator
Copy link
Contributor Author

run tests

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 21, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [ycombinator commented: jenkins, run tests please]

  • Start Time: 2020-05-21T03:00:49.777+0000

  • Duration: 76 min 42 sec (4541656)

Test stats 🧪

Test Results
Failed 0
Passed 9214
Skipped 1542
Total 10756

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 2 min 22 sec

    • Start Time: 2020-05-21T03:39:22.308+0000

    • log

  • Name: Make -C generator/_templates/metricbeat test

    • Description: make -C generator/_templates/metricbeat test

    • Result: FAILURE

    • Duration: 6 min 0 sec

    • Start Time: 2020-05-21T04:02:37.917+0000

    • log

@ycombinator
Copy link
Contributor Author

jenkins, run tests please

@ycombinator ycombinator merged commit 34af60d into elastic:master May 21, 2020
@ycombinator ycombinator deleted the lockfile-better-error branch May 21, 2020 10:52
@ycombinator ycombinator mentioned this pull request May 21, 2020
Merged
ycombinator added a commit to ycombinator/beats that referenced this pull request May 21, 2020
@ycombinator
Make error message actionable (elastic#18667)
a015df7 
* Make error message actionable

* Adding CHANGELOG entry
ycombinator added a commit to ycombinator/beats that referenced this pull request May 21, 2020
@ycombinator
Make error message actionable (elastic#18667)
4cdc85e 
* Make error message actionable

* Adding CHANGELOG entry
@ycombinator ycombinator mentioned this pull request May 21, 2020
Merged
ycombinator added a commit that referenced this pull request May 27, 2020
@ycombinator
[7.x] Make error message actionable (#18667) (#18686)
8133cbf 
* Make error message actionable (#18667)

* Make error message actionable

* Adding CHANGELOG entry

* Cleaning up CHANGELOG
ycombinator added a commit that referenced this pull request May 27, 2020
@ycombinator
[7.8] Make error message actionable (#18667) (#18687)
f911997 
* Make error message actionable (#18667)

* Make error message actionable

* Adding CHANGELOG entry

* Cleaning up CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresrc andresrc andresrc approved these changes

@kvch kvch kvch approved these changes

@urso urso Awaiting requested review from urso

Assignees
No one assigned
Labels
libbeat needs_backport PR is waiting to be backported to other branches. Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @elasticmachine @andresrc @kvch