[Journalbeat] Add ID config option input #18467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
andrewkroh
added
the
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
andrewkroh
force-pushed
the
feature/jb/input-id
branch
from
6db8ad3
to
bdbd1b3
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
|
Add an `id` configuration option to the Journalbeat input to make it possible to start multiple inputs on the same journal. As an administrator this provides more flexibility in how you can deploy Journalbeat. It gives you the configuration grainularity you need to be able to have an input for each service or log type. You can apply different `include_matches` to each input. And you can easily add new log types at any point and make Journalbeat read all matching logs from the "head" without affecting existing input cursor positions. I also fixed a test that was modifying a file under source control by copying it into the build directory before applying changes.
andrewkroh
force-pushed
the
feature/jb/input-id
branch
from
bdbd1b3
to
2b34160
Compare
|
run tests |
kvch
approved these changes
May 15, 2020
6 tasks
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
May 15, 2020
Add an `id` configuration option to the Journalbeat input to make it possible to start multiple inputs on the same journal. As an administrator this provides more flexibility in how you can deploy Journalbeat. It gives you the configuration grainularity you need to be able to have an input for each service or log type. You can apply different `include_matches` to each input. And you can easily add new log types at any point and make Journalbeat read all matching logs from the "head" without affecting existing input cursor positions. I also fixed a test that was modifying a file under source control by copying it into the build directory before applying changes. (cherry picked from commit 74a5bd2)
andrewkroh
added a commit
that referenced
this pull request
May 19, 2020
Add an `id` configuration option to the Journalbeat input to make it possible to start multiple inputs on the same journal. As an administrator this provides more flexibility in how you can deploy Journalbeat. It gives you the configuration grainularity you need to be able to have an input for each service or log type. You can apply different `include_matches` to each input. And you can easily add new log types at any point and make Journalbeat read all matching logs from the "head" without affecting existing input cursor positions. I also fixed a test that was modifying a file under source control by copying it into the build directory before applying changes. (cherry picked from commit 74a5bd2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an
idconfiguration option to the Journalbeat input to make it possibleto start multiple inputs on the same journal.
I also fixed a test that was modifying a file under source control by copying it
into the build directory before applying changes.
Why is it important?
As an administrator this provides more flexibility in how you can deploy
Journalbeat. It gives you the configuration grainularity you need to be able
to have an input for each service or log type. You can apply different
include_matchesto each input. And you can easily add new log types at anypoint and make Journalbeat read all matching logs from the "head" without
affecting existing input cursor positions.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Relates: #10985
Use cases
The configuration I push out to Journalbeat depends on what particular services are deployed on that node. This allows me to setup one input for each service.