Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #17960 to 7.x: Allow CLI paths override #18169

Merged
merged 1 commit into from
May 4, 2020
Merged

Cherry-pick #17960 to 7.x: Allow CLI paths override #18169

merged 1 commit into from
May 4, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #17781 to 7.x branch. Original message:

What does this PR do?

Allowing override of configuration using -E flag of two specific cases --path.data --path.home

Why is it important?

Allows having data (download, install) outside of agent directory without manually changing configuration file

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added backport Project:fleet Ingest Management:alpha1 Group issues for ingest management alpha1 labels May 4, 2020
@michalpristas michalpristas requested a review from ph May 4, 2020 12:00
@michalpristas michalpristas self-assigned this May 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
@michalpristas michalpristas mentioned this pull request May 4, 2020
Merged
6 tasks
@michalpristas michalpristas added review Team:Ingest Management and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 4, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@michalpristas michalpristas merged commit e107dc4 into elastic:7.x May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees

@michalpristas michalpristas

Labels
backport Ingest Management:alpha1 Group issues for ingest management alpha1 review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @ph