Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Improve ECS categorization field mappings for nats module #17550

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Adds ECS categorization fields to nats module.

Why is it important?

ECS categorization fields improve experience in SIEM module and across inputs from different sources.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=nats mage -v pythonIntegTest

Related issues

Closes #16173

@leehinman leehinman added enhancement Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:SIEM ecs labels Apr 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

- event.kind
- event.type
- related.ip

Closes elastic#16173
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leehinman leehinman merged commit eb5ba9a into elastic:master Apr 16, 2020
@leehinman leehinman deleted the 16173_nats_ecs_1.4 branch April 16, 2020 13:46
leehinman added a commit to leehinman/beats that referenced this pull request Apr 16, 2020
…lastic#17550)

* Improve ECS categorization field mappings for nats module

- event.kind
- event.type
- related.ip

Closes elastic#16173

(cherry picked from commit eb5ba9a)
@leehinman leehinman added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 16, 2020
leehinman added a commit to leehinman/beats that referenced this pull request Apr 16, 2020
…lastic#17550)

* Improve ECS categorization field mappings for nats module

- event.kind
- event.type
- related.ip

Closes elastic#16173

(cherry picked from commit eb5ba9a)
leehinman added a commit that referenced this pull request Apr 16, 2020
…17550) (#17755)

* Improve ECS categorization field mappings for nats module

- event.kind
- event.type
- related.ip

Closes #16173

(cherry picked from commit eb5ba9a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] Upgrade nats module to ECS 1.4
3 participants