Add data directories to kubernetes manifests #17429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mount data directories in Metricbeat and Auditbeat pods too. They were defined in some places but not mounted. For Auditbeat this is important so it doesn't have to rebuild its file integrity database on each run. For Metricbeat I don't think it is so important, but adding it just in case for consistency with the other reference manifests.
jsoriano
added
review
Metricbeat
|
Pinging @elastic/siem (Team:SIEM) |
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
exekias
approved these changes
Apr 2, 2020
|
This may worth a changelog? |
Changelog entries added, and while adding them I saw that it didn't make sense to add a data directory to the metricbeat deployment because the instance can be run on any node, so I have reverted this part. This would be ready for another look. |
andrewkroh
approved these changes
Apr 6, 2020
exekias
approved these changes
Apr 6, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Apr 6, 2020
Mount data directories in Metricbeat and Auditbeat pods too. They were defined in some places but not mounted. For Auditbeat this is important so it doesn't have to rebuild its file integrity database on each run. For Metricbeat I don't think it is so important, but adding it just in case for consistency with the other reference manifests. (cherry picked from commit 257f0cc)
jsoriano
added
v7.8.0
and removed
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Apr 6, 2020
Mount data directories in Metricbeat and Auditbeat pods too. They were defined in some places but not mounted. For Auditbeat this is important so it doesn't have to rebuild its file integrity database on each run. For Metricbeat I don't think it is so important, but adding it just in case for consistency with the other reference manifests. (cherry picked from commit 257f0cc)
jsoriano
added a commit
that referenced
this pull request
Apr 6, 2020
Mount data directories in Metricbeat and Auditbeat pods too. They were defined in some places but not mounted. For Auditbeat this is important so it doesn't have to rebuild its file integrity database on each run. For Metricbeat I don't think it is so important, but adding it just in case for consistency with the other reference manifests. (cherry picked from commit 257f0cc)
jsoriano
added a commit
that referenced
this pull request
Apr 6, 2020
Mount data directories in Metricbeat and Auditbeat pods too. They were defined in some places but not mounted. For Auditbeat this is important so it doesn't have to rebuild its file integrity database on each run. For Metricbeat I don't think it is so important, but adding it just in case for consistency with the other reference manifests. (cherry picked from commit 257f0cc)
This was referenced Apr 8, 2020
Merged
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…#17509) Mount data directories in Metricbeat and Auditbeat pods too. They were defined in some places but not mounted. For Auditbeat this is important so it doesn't have to rebuild its file integrity database on each run. For Metricbeat I don't think it is so important, but adding it just in case for consistency with the other reference manifests. (cherry picked from commit 168d8eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount data directories in Metricbeat and Auditbeat pods too. They were
defined in some places but not mounted.
For Auditbeat this is important so it doesn't have to rebuild its file
integrity database on each run. For Metricbeat I don't think it is so
important, but adding it just in case for consistency with the other
reference manifests. Filebeat is already mounting its data directory.