-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable remote_write and query metricsets from Prom default config #17278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
review
[zube]: In Review
Team:Platforms
Label for the Integrations - Platforms team
labels
Mar 27, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
ChrsMark
added
needs_backport
PR is waiting to be backported to other branches.
v7.7.0
labels
Mar 27, 2020
Thank you for opening! Could you comment with all beats/metricbeat/modules.d/system.yml Lines 38 to 42 in 0ef4722
|
Signed-off-by: chrismark <chrismarkou92@gmail.com>
exekias
approved these changes
Mar 27, 2020
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Mar 27, 2020
…lastic#17278) (cherry picked from commit 697c016)
ChrsMark
added
v7.8.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Mar 27, 2020
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Mar 27, 2020
…lastic#17278) (cherry picked from commit 697c016)
ChrsMark
added a commit
that referenced
this pull request
Mar 27, 2020
ChrsMark
added a commit
that referenced
this pull request
Mar 27, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#17278) (elastic#17281) (cherry picked from commit 8f05a27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disables the
remote_write
andquery
metricsets from the default configuration. Users should manually enable them.Why is it important?
We don't want them to be enabled by default since these are special ones.
cc: @exekias