Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable remote_write and query metricsets from Prom default config #17278

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

ChrsMark
Copy link
Member

What does this PR do?

This PR disables the remote_write and query metricsets from the default configuration. Users should manually enable them.

Why is it important?

We don't want them to be enabled by default since these are special ones.

cc: @exekias

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added review [zube]: In Review Team:Platforms Label for the Integrations - Platforms team labels Mar 27, 2020
@ChrsMark ChrsMark requested review from a team March 27, 2020 09:01
@ChrsMark ChrsMark self-assigned this Mar 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@ChrsMark ChrsMark added needs_backport PR is waiting to be backported to other branches. v7.7.0 labels Mar 27, 2020
@exekias
Copy link
Contributor

exekias commented Mar 27, 2020

Thank you for opening! Could you comment with all # in the same column? that should make it easier to remove them, like here:

#- module: system
# period: 5m
# metricsets:
# - raid
# raid.mount_point: '/'

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark merged commit 697c016 into elastic:master Mar 27, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Mar 27, 2020
@ChrsMark ChrsMark added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 27, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Mar 27, 2020
ChrsMark added a commit that referenced this pull request Mar 27, 2020
ChrsMark added a commit that referenced this pull request Mar 27, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team v7.7.0 v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants