Cherry-pick #16013 to 7.x: Add translate_sid processor to Winlogbeat #16941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add translate_sid processor to Winlogbeat The `translate_sid` processor translates a Windows security identifier (SID) into an account name. It retrieves the name of the account associated with the SID, the first domain on which the SID is found, and the type of account. Closes elastic#7451 (cherry picked from commit 65b31bd)
andresrc
added
[zube]: Inbox
[zube]: In Review
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
|
Pinging @elastic/siem (Team:SIEM) |
dedemorton
reviewed
Mar 11, 2020
| @@ -98,6 +98,9 @@ endif::[] | |||
| ifndef::no_truncate_fields_processor[] | |||
| * <<truncate-fields, `truncate_fields`>> | |||
| endif::[] | |||
| ifdef::no_translate_sid_processor[] | |||
There was a problem hiding this comment.
I think you meant ifndef here.
There was a problem hiding this comment.
That's fixed in #16961 and I'll backport it too.
dedemorton
reviewed
Mar 11, 2020
| @@ -197,5 +200,8 @@ endif::[] | |||
| ifndef::no_truncate_fields_processor[] | |||
| include::{libbeat-processors-dir}/actions/docs/truncate_fields.asciidoc[] | |||
| endif::[] | |||
| ifdef::no_translate_sid_processor[] | |||
There was a problem hiding this comment.
same comment as earlier about ifndef
dedemorton
approved these changes
Mar 12, 2020
andrewkroh
commented
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16013 to 7.x branch. Original message:
The
translate_sidprocessor translates a Windows security identifier (SID)into an account name. It retrieves the name of the account associated with the
SID, the first domain on which the SID is found, and the type of account.
Closes #7451