Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metricbeat system test fixes (Python3 branch) #15779

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Metricbeat system test fixes (Python3 branch) #15779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions metricbeat/module/elasticsearch/test_elasticsearch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def test_metricsets(self, metricset):
self.check_metricset("elasticsearch", metricset, self.get_hosts(), self.FIELDS +
["service"], extras={"index_recovery.active_only": "false"})

@unittest.skipUnless(metricbeat.INTEGRATION_TESTS, "integration test")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, isn't it failing in master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably should be failing in master. Perhaps we don't run these tests outside of the INTEGRATION_TEST=true environment any where on CI.

def test_xpack(self):
"""
elasticsearch-xpack module tests
Expand Down