New hashing algorithm for fingerprint processor

[rvillablanca]

This adds a the xxHash hashing to the list of available methods in the fingerprint processor.

Solves #15080

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[rvillablanca]

Ready to be reviewed @ycombinator

[ycombinator]

CI fails like so:

>> check: Checking source code for common problems
processors/fingerprint/hash.go:28:2: cannot find package "github.com/OneOfOne/xxhash" in any of:
	/home/travis/gopath/src/github.com/elastic/beats/vendor/github.com/OneOfOne/xxhash (vendor tree)
	/home/travis/.gimme/versions/go1.13.5.linux.amd64/src/github.com/OneOfOne/xxhash (from $GOROOT)
	/home/travis/gopath/src/github.com/OneOfOne/xxhash (from $GOPATH)

This is because we need to vendor the github.com/OneOfOne/xxhash package as part of this PR.

[ycombinator]

jenkins, test this

[ycombinator]

Could you also add a line about this enhancement in the CHANGELOG.next.asciidoc file?

[rvillablanca]

CI fails like so:

>> check: Checking source code for common problems
processors/fingerprint/hash.go:28:2: cannot find package "github.com/OneOfOne/xxhash" in any of:
	/home/travis/gopath/src/github.com/elastic/beats/vendor/github.com/OneOfOne/xxhash (vendor tree)
	/home/travis/.gimme/versions/go1.13.5.linux.amd64/src/github.com/OneOfOne/xxhash (from $GOROOT)
	/home/travis/gopath/src/github.com/OneOfOne/xxhash (from $GOPATH)

This is because we need to vendor the github.com/OneOfOne/xxhash package as part of this PR.

@ycombinator Do you have vendoring process automated with any make/mage task or should I copy manually the dependency ? I was looking for some task but without success

[ycombinator]

Do you have vendoring process automated with any make/mage task or should I copy manually the dependency ?

We use govendor. See https://www.elastic.co/guide/en/beats/devguide/current/beats-contributing.html#dependencies.

[rvillablanca]

Ok all sugestions were solved

[ycombinator]

@rvillablanca Left a couple of minor suggestions but this is looking good otherwise!

[ycombinator]

BTW, looks like CI is now failing on an outdated NOTICE.txt file. This should be fixed if you run make notice in the root directory.

[rvillablanca]

I will check

[ycombinator]

Also, could you add the new hash method (xxhash) to the fingerprint processor docs? See https://github.com/elastic/beats/blob/master/libbeat/processors/fingerprint/docs/fingerprint.asciidoc.

[ycombinator]

jenkins, test this

[ycombinator]

LGTM! Thanks for the contribution @rvillablanca and for working through the issue with the hash.Hash interface. I'll merge this once CI looks good.

[rvillablanca]

I think we are done with all @ycombinator, any questions do not hesitate to ask me

[ycombinator]

NOTICE.txt needs an update again, since the version of the dependency was updated.

[rvillablanca]

Ok NOTICE.txt updated

[ycombinator]

jenkins, test this

[ycombinator]

Travis CI is green. Jenkins CI failures are unrelated. Merging.