[Metricbeat] Fix ARN parsing function to work for ELB ANRs #14316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
Team:Integrations
fearful-symmetry
approved these changes
Oct 29, 2019
kaiyan-sheng
added a commit
that referenced
this pull request
Oct 30, 2019
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
…4316) * Fix findIdentifierFromARN to work for elb arns
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…4316) (elastic#14319) * Fix findIdentifierFromARN to work for elb arns (cherry picked from commit b23bc3d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a bug in ARN parser
findIdentifierFromARN. It used to only work for arns with short resource string with only two parts, such asinstance/i-123. Now with this change, the parser should work for other resource strings as well with more than two parts, such asloadbalancer/net/ece-es-clusters-nlb/0c5bdb3b96cf1552.Unit test is added for this.