Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date parsing in MySQL error fileset #14130

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 18, 2019

MySQL error logs can contain timestamps with or without timezones, add
date parsers for both cases. Also remove some spurious spaces from
parsed messages, and add previously unsupported date patterns.

Consider lines without timestamp as part of the previous message, if
not, lines without timestamp will appear disordered respect to lines with
timestamps in Kibana. And joined lines are always related, at least in
the cases we have.

Fixes #14076

MySQL error logs can contain timestamps with or without timezones, add
date parsers for both cases. Also remove some spurious spaces from
parsed messages.
@jsoriano jsoriano added bug module review Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Integrations Label for the Integrations team v7.5.0 labels Oct 18, 2019
@jsoriano jsoriano requested a review from a team as a code owner October 18, 2019 11:51
@jsoriano jsoriano self-assigned this Oct 18, 2019
vagrant@precise32:~$ less /var/log/mysql/
error.log mysql-slow.log
vagrant@precise32:~$ less /var/log/mysql/error.log
vagrant@precise32:~$ cat /var/log/mysql/error.log
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these lines were here by mistake.

@jsoriano jsoriano merged commit cf5595a into elastic:master Oct 18, 2019
@jsoriano jsoriano deleted the mysql-error-log-timezones branch October 18, 2019 15:20
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Oct 18, 2019
jsoriano added a commit to jsoriano/beats that referenced this pull request Oct 18, 2019
MySQL error logs can contain timestamps with or without timezones, add
date parsers for both cases. Also remove some spurious spaces from
parsed messages, and add previously unsupported date patterns.

Consider lines without timestamp as part of the previous message. If
not, lines without timestamp will appear disordered respect to lines with
timestamps in Kibana. And joined lines are always related, at least in
the tests cases we have.

(cherry picked from commit cf5595a)
jsoriano added a commit that referenced this pull request Oct 27, 2019
MySQL error logs can contain timestamps with or without timezones, add
date parsers for both cases. Also remove some spurious spaces from
parsed messages, and add previously unsupported date patterns.

Consider lines without timestamp as part of the previous message. If
not, lines without timestamp will appear disordered respect to lines with
timestamps in Kibana. And joined lines are always related, at least in
the tests cases we have.

(cherry picked from commit cf5595a)
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
MySQL error logs can contain timestamps with or without timezones, add
date parsers for both cases. Also remove some spurious spaces from
parsed messages, and add previously unsupported date patterns.

Consider lines without timestamp as part of the previous message. If
not, lines without timestamp will appear disordered respect to lines with
timestamps in Kibana. And joined lines are always related, at least in
the tests cases we have.
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
MySQL error logs can contain timestamps with or without timezones, add
date parsers for both cases. Also remove some spurious spaces from
parsed messages, and add previously unsupported date patterns.

Consider lines without timestamp as part of the previous message. If
not, lines without timestamp will appear disordered respect to lines with
timestamps in Kibana. And joined lines are always related, at least in
the tests cases we have.

(cherry picked from commit dd49581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mysql filebeat module [mysql.error] ingest pipeline issue
3 participants