-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state field for connection metricset from RabbitMQ module (#13697) #WIP #13981
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Thank you for opening this @amandahla! Can you please update |
Fixes #13697 |
Hi @amandahla this looks good, but I noticed some indentation at golden/JSON files that lead me to think you are manually editing them. Would you mind to: cd GOPATH/src/github.com/elastic/beats/metricbeat/module/rabbitmq/connection
go test ./... -generate that command should generate both JSON files with correct indentation. |
@odacremolbap done! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @amandahla
please, proceed to merge
Add state field for connectino metricset. Still needs to test in real environment.