Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in Redis key metricset #13426

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Conversation

jsoriano
Copy link
Member

If a key is removed during a fetch, FetchKeyInfo returns a nil object,
this nil object should be ignored, if passed to eventMapping it
panics.

Reported in https://discuss.elastic.co/t/panic-in-redis-module/197253

If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.
@jsoriano jsoriano added bug module Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.4.0 v7.2.2 v7.3.2 v6.8.4 labels Aug 29, 2019
@jsoriano jsoriano requested a review from a team as a code owner August 29, 2019 20:40
@jsoriano jsoriano self-assigned this Aug 29, 2019
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsoriano jsoriano merged commit 99ded55 into elastic:master Aug 30, 2019
@jsoriano jsoriano deleted the fix-redis-key-panic branch August 30, 2019 10:45
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Aug 30, 2019
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 99ded55)
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 99ded55)
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 99ded55)
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 99ded55)
jsoriano added a commit that referenced this pull request Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 99ded55)
jsoriano added a commit that referenced this pull request Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 99ded55)
jsoriano added a commit that referenced this pull request Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 99ded55)
jsoriano added a commit that referenced this pull request Aug 30, 2019
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 99ded55)
@jsoriano jsoriano removed the v6.8.3 label Oct 8, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 318a041)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 318a041)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
If a key is removed during a fetch, `FetchKeyInfo` returns a nil object,
this nil object should be ignored, if passed to `eventMapping` it
panics.

(cherry picked from commit 318a041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants