-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aws cloudwatch msk #13389
Aws cloudwatch msk #13389
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins, test this please |
@thenom Thank you for creating this PR and making this great change in cloudwatch metricset! I see that you are making the change based on 7.3 branch. Could you create a PR based on master please? Then we can backport it to 7.3 and 7.4 after it gets merged. |
3cab5cc
to
c9ca958
Compare
Hi @kaiyan-sheng , thanks for taking a look. I have rebased this on master and local tests are passing. |
jenkins, test this please |
Thank you! Could you please add a changelog entry in |
Yep no problem, entry added:
|
jenkins, test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works. Thanks again for your contribution @thenom!
Brilliant, @kaiyan-sheng thanks again 👍 |
Added label seperator and split the labels based on that instead of spaces. Some dimensions include spaces so was breaking the generation of the event, for example:
This label:
KafkaAppLogsDiskUsed AWS/Kafka Cluster Name,Broker ID test-kafka,1
was generating:
instead of:
And a side affect of this is it was creating an event for every metric.