Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container image in Kubernetes metadata #13356

Merged
merged 4 commits into from
Aug 28, 2019
Merged

Add container image in Kubernetes metadata #13356

merged 4 commits into from
Aug 28, 2019

Conversation

ChrsMark
Copy link
Member

Fixes #12688

@ChrsMark ChrsMark requested a review from jsoriano August 27, 2019 12:50
@ChrsMark ChrsMark self-assigned this Aug 27, 2019
@ChrsMark ChrsMark added Team:Integrations Label for the Integrations team in progress Pull request is currently in progress. [zube]: In Progress labels Aug 27, 2019
jsoriano
jsoriano approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests go green.

kaiyan-sheng
kaiyan-sheng approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsoriano
Copy link
Member

@ChrsMark you will need to resolve the merge conflict. You can ignore failures in Windows jobs.

@ChrsMark ChrsMark requested a review from a team as a code owner August 27, 2019 21:07
@ChrsMark
Add container image in Kubernetes metadata
69320cb 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark
Add changelog entry
22c8172 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark
Fix tests
cec659e 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark
fmt files
deee82c 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark merged commit aa3f38d into elastic:master Aug 28, 2019
@ChrsMark ChrsMark added v7.4.0 test-plan Add this PR to be manual test plan and removed in progress Pull request is currently in progress. labels Aug 28, 2019
@ChrsMark ChrsMark deleted the add_image_k8s_metadata branch August 28, 2019 12:02
@westwind-sc westwind-sc mentioned this pull request Aug 4, 2020
Closed
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Sep 30, 2020
@ChrsMark
Add container image in Kubernetes metadata (elastic#13356)
423d027 
(cherry picked from commit aa3f38d)
@ChrsMark ChrsMark mentioned this pull request Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@ChrsMark ChrsMark

Labels
Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add container image to default Kubernetes metadata
4 participants
@ChrsMark @jsoriano @kaiyan-sheng @andresrc