Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functionbeat] fix cloudwatch logs timestamp to use logRecord timestamp… #13291

Merged
merged 3 commits into from
Aug 27, 2019

Conversation

sbasgall
Copy link
Contributor

… instead of record processing timestamp

The suggested TODO code passes the Cloudwatch timestamp as seconds. The Cloudwatch field value is milliseconds. Pass it as nanoseconds times 1000000.

Closes: #12412

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sbasgall
Copy link
Contributor Author

When I run mage fmt update as suggested by the CI I get an error

If I run it from the root of the repo: I see unknown target specified: update
If I run it from the x-pack/functionbeat directory: I see Unknown target specified: fmt

I'm happy to make any changes needed but could use some guidance.

Thank you!

@kaiyan-sheng
Copy link
Contributor

For your question about mage, maybe run mage fmt under x-pack/functionbeat 😬

@sbasgall sbasgall changed the title fix functionbeat cloudwatch logs timestamp to use logRecord timestamp… [Functionbeat] fix functionbeat cloudwatch logs timestamp to use logRecord timestamp… Aug 20, 2019
@sbasgall sbasgall changed the title [Functionbeat] fix functionbeat cloudwatch logs timestamp to use logRecord timestamp… [Functionbeat] fix cloudwatch logs timestamp to use logRecord timestamp… Aug 20, 2019
@sbasgall
Copy link
Contributor Author

@kaiyan-sheng Thank you! I was able to just run mage fmt from the root of the whole repo and it fixed my formatting error.

@sbasgall
Copy link
Contributor Author

Should I not be using master branch in my forked source branch?

@ph
Copy link
Contributor

ph commented Aug 22, 2019

@sbasgall Fixes look good to me, can we add a simple test in https://github.com/elastic/beats/blob/master/x-pack/functionbeat/provider/aws/aws/transformer/transformer_test.go to make sure we never have a regression on it.

@kvch
Copy link
Contributor

kvch commented Aug 23, 2019

jenkins test this

@ph
Copy link
Contributor

ph commented Aug 27, 2019

@kvch I think we can merge this as is and we can add a test in the #13317 PR

Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kvch kvch merged commit d9a85ad into elastic:master Aug 27, 2019
kvch added a commit that referenced this pull request Aug 27, 2019
@sbasgall
Copy link
Contributor Author

sbasgall commented Sep 6, 2019

Thank you all so much, Last week we were in the final stages of our migration to Elastic and I was unable to find any quiet time to write the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functionbeat forwards incorrect timestamp
5 participants