Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse connections in redis info metricset #12950

Merged
merged 3 commits into from
Jul 18, 2019
Merged

Reuse connections in redis info metricset #12950

merged 3 commits into from
Jul 18, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jul 17, 2019 •
edited by zube bot
Loading

Continues with #12914

@jsoriano jsoriano added bug module review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Integrations Label for the Integrations team labels Jul 17, 2019
@jsoriano jsoriano requested a review from a team as a code owner July 17, 2019 17:23
@jsoriano jsoriano self-assigned this Jul 17, 2019
@sayden
Copy link
Contributor

sayden commented Jul 18, 2019

Changelog entry?

@sayden
Copy link
Contributor

sayden commented Jul 18, 2019

It will be nice to take advantage in this PR's to start debugging the errors returned when trying to close connections (line 56 defer conn.Close()). The reason is because I sometimes see questions in discuss related with the number of opened connections by some modules, that maybe and only maybe, might be caused by an error trying to close the connection to the service.

@jsoriano
Copy link
Member Author

@sayden I have extended the changelog entry for #12914, I have also added the logging of the close errors, though I think it is not needed in this case as current implementation cannot return an error (it is a connection from a pool and it is only released, not really closed). Please take another look.

@sayden sayden self-requested a review July 18, 2019 14:10
sayden
sayden approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think it's better to play safe if you also agreed :)

@jsoriano jsoriano merged commit 4d207e7 into elastic:master Jul 18, 2019
@jsoriano jsoriano deleted the redis-info-connection-close branch July 18, 2019 15:42
jsoriano added a commit to jsoriano/beats that referenced this pull request Jul 18, 2019
@jsoriano
Reuse connections in redis info metricset (elastic#12950)
af581d8 
Reuse connections in redis info metricset, and log close
errors at the debug level.

(cherry picked from commit 4d207e7)
@jsoriano jsoriano mentioned this pull request Jul 18, 2019
Merged
@jsoriano jsoriano added v7.3.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jul 18, 2019
jsoriano added a commit that referenced this pull request Jul 19, 2019
@jsoriano
Cherry-pick #12950 to 7.3: Reuse connections in redis info metricset (#…
a081d96 
…12967)

Reuse connections in redis info metricset, and log close
errors at the debug level.

(cherry picked from commit 4d207e7)
@jsoriano jsoriano mentioned this pull request Jul 19, 2019
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Jul 19, 2019
@jsoriano
Reuse connections in redis info metricset (elastic#12950)
d2ef53d 
Reuse connections in redis info metricset, and log close
errors at the debug level.

(cherry picked from commit 4d207e7)
@jsoriano jsoriano mentioned this pull request Jul 19, 2019
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Jul 19, 2019
@jsoriano
Reuse connections in redis info metricset (elastic#12950)
6e8e06d 
Reuse connections in redis info metricset, and log close
errors at the debug level.

(cherry picked from commit 4d207e7)
jsoriano added a commit that referenced this pull request Jul 19, 2019
@jsoriano
Reuse connections in redis info metricset (#12950) (#12979)
aa0a1d8 
Reuse connections in redis info metricset, and log close
errors at the debug level.

(cherry picked from commit 4d207e7)
jsoriano added a commit that referenced this pull request Jul 23, 2019
@jsoriano
Cherry-pick #12950 to 7.1: Reuse connections in redis info metricset (#…
661cc72 
…12980)

Reuse connections in redis info metricset, and log close
errors at the debug level.

(cherry picked from commit 4d207e7)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Reuse connections in redis info metricset (elastic#12950) (elastic#12979
2bd83c3 
)

Reuse connections in redis info metricset, and log close
errors at the debug level.

(cherry picked from commit d9e4e9b)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Cherry-pick elastic#12950 to 7.1: Reuse connections in redis info met…
598343f 
…ricset (elastic#12980)

Reuse connections in redis info metricset, and log close
errors at the debug level.

(cherry picked from commit d9e4e9b)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Cherry-pick elastic#12950 to 7.3: Reuse connections in redis info met…
7c9f786 
…ricset (elastic#12967)

Reuse connections in redis info metricset, and log close
errors at the debug level.

(cherry picked from commit d9e4e9b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@jsoriano jsoriano

Labels
bug Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team v7.1.2 v7.2.1 v7.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoriano @sayden @kaiyan-sheng @andresrc