Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.12.7 #12931

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Conversation

mikemadden42
Copy link
Contributor

No description provided.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should have a CHANGELOG entry.

Copy link
Contributor Author

@mikemadden42 mikemadden42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog is added.

@mikemadden42 mikemadden42 merged commit eae3e45 into elastic:master Jul 16, 2019
@mikemadden42 mikemadden42 deleted the update-go-1.12.7 branch July 16, 2019 22:06
@@ -15,6 +15,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Update to ECS 1.0.1. {pull}12284[12284] {pull}12317[12317]
- Default of output.kafka.metadata.full is set to false by now. This reduced the amount of metadata to be queried from a kafka cluster. {pull}12738[12738]
- Fixed a crash under Windows when fetching processes information. {pull}12833[12833]
- Update to Golang 1.12.7. {pull}12931[12931]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future.

The Changelog.next.asciidoc is for users only. If we fix important bugs by upgrading go, then we should add Fix xyz in this file. But the fact that the toolchain has been updated is maybe better put in Changelog-developer.next.asciidoc. WDYT?

mikemadden42 added a commit to mikemadden42/beats that referenced this pull request Jul 18, 2019
* Update Go to 1.12.7

* Add changelog entry for Go 1.12.7

(cherry picked from commit eae3e45)
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
* Update Go to 1.12.7

* Add changelog entry for Go 1.12.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants