Fix keyspace configuration in redis key metricset #12913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incoherent behaviour when keyspace is specified in the redis host URL and not in some of the key patterns. If it was not specified it used the default 0 instead of using the one in the redis host.
jsoriano
added
bug
module
review
needs_backport
houndci-bot
reviewed
Jul 15, 2019
houndci-bot
reviewed
Jul 15, 2019
jsoriano
added
[zube]: In Progress
in progress
|
One test is flaky |
houndci-bot
reviewed
Jul 17, 2019
houndci-bot
reviewed
Jul 17, 2019
houndci-bot
reviewed
Jul 17, 2019
jsoriano
added
[zube]: In Review
review
and removed
[zube]: In Progress
in progress
Fixed, the method I was using to get current keyspace was not reliable, according to documentation client should keep track of the keyspace selected, so changed to this method. |
kaiyan-sheng
approved these changes
Jul 18, 2019
|
jenkins, test this again please |
1 similar comment
|
jenkins, test this again please |
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jul 22, 2019
Fix incoherent behaviour when keyspace is specified in the redis host URL and not in some of the key patterns. If it was not specified it used the default 0 instead of using the one configured in the redis host. (cherry picked from commit 03d7870)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… key metricset (elastic#12999) Fix incoherent behaviour when keyspace is specified in the redis host URL and not in some of the key patterns. If it was not specified it used the default 0 instead of using the one configured in the redis host. (cherry picked from commit 7bad0a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incoherent behaviour when keyspace is specified in the redis host
URL and not in some of the key patterns. If it was not specified it used
the default 0 instead of using the one in the redis host.
Redis doesn't have a direct way to request the keyspace being currently
used by a client, documentation mentions that is responsibility of the
client to keep track of the keyspace used if it changes it using
Select.This solution stores the db number originally configured and uses it
in the
keymetricset if no other keyspace is configured.Fixes #12874