Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kafka output metadata fetch #12738

Merged
merged 3 commits into from
Jul 2, 2019

Conversation

urso
Copy link

@urso urso commented Jul 1, 2019

Change default metadata request configuration in the kafka output to
only collect metadata of topics we publish to. Given that beats publish to one public only by default, it makes sense to reduce the number of metadata we fetch and renew from a cluster.

Only users publishing to a number of topics might want to set this to true.

Change default metadata request configuration in the kafka output to
only collect metadata of topics we publish to.
@urso urso requested a review from a team as a code owner July 1, 2019 14:14
@urso urso requested review from a team as code owners July 1, 2019 14:20
@urso urso removed request for a team July 1, 2019 14:24
@urso urso added the review label Jul 1, 2019
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urso
Copy link
Author

urso commented Jul 1, 2019

Jenkins, test this.

@kvch
Copy link
Contributor

kvch commented Jul 1, 2019

jenkins test this

@urso urso merged commit 0316e70 into elastic:master Jul 2, 2019
@urso urso deleted the kafka-output-metadata-full-false branch July 5, 2019 23:34
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
Change default metadata request configuration in the kafka output to
only collect metadata of topics we publish to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants