-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional fields to MySQL module #12227
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition, thanks!
@aidarbek, could you regenerate the data.json
file for the status metricset so it shows the new metrics? You can do it by running go test -tags=integration ./metricbeat/module/mysql/status -data
. If you have any problem with that I am happy to do it myself in a follow up PR.
Hi @jsoriano, thanks for feedback. I thought that |
Thanks! It looks great. |
jenkins, test this please |
Jenkins, test this again please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for green
@jsoriano could you merge it, if everything is OK? :) |
Thanks @aidarbek! Great work here 🙂 |
@jsoriano Excuse me but, Is it live yet? I'm not sure if we need to wait for a specific release of the beats package or something. |
@Cho1409 this change will be released on Metricbeat 7.3.0. |
Fixes #12088