Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Refactor autodiscover default input settings handling #12193

Merged
merged 5 commits into from
May 24, 2019

Commits on May 20, 2019

  1. Move default config logic to the builder

    Autodiscover hints default config (unreleased) was done at the hints
    level, while it only makes sense for certain configs builder (logs).
    
    This change moves this logic to the `logs` builder and improves how
    users can define default settings for logs, ie:
    
    Enable hints but disable log retrieval by default:
    
    ```
    filebeat.autodiscover:
      providers:
        - type: docker # or kubernetes
          hints.enabled: true
          hints.default_config.enabled: false
    ```
    
    Only containers with the `co.elastic.logs/enabled: true` annotation
    will be retrieved.
    
    ```
    filebeat.autodiscover:
      providers:
        - type: kubernetes # or docker
          hints.enabled: true
          hints.default_config:
            type: container
            paths:
              - /var/log/containers/*${data.container.id}.log
    ```
    
    Logs are read by default for all containers, using the given input
    settings. Containers with `co.elastic.logs/enabled: false` annotation
    will be ignored.
    Carlos Pérez-Aradros Herce committed May 20, 2019
    Configuration menu
    Copy the full SHA
    489b6f1 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. Update docs

    Carlos Pérez-Aradros Herce committed May 22, 2019
    Configuration menu
    Copy the full SHA
    339db65 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2019

  1. Add integration test

    Carlos Pérez-Aradros Herce committed May 23, 2019
    Configuration menu
    Copy the full SHA
    c876069 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. Update CHANGELOG

    Carlos Pérez-Aradros Herce committed May 24, 2019
    Configuration menu
    Copy the full SHA
    65ef6b8 View commit details
    Browse the repository at this point in the history
  2. Update changelog

    Carlos Pérez-Aradros Herce committed May 24, 2019
    Configuration menu
    Copy the full SHA
    f8b47b4 View commit details
    Browse the repository at this point in the history