Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #11982 to 7.0: Change type from scaled_float to long and add format (#11982) #12158

Merged
merged 3 commits into from
May 16, 2019
Merged

Cherry-pick #11982 to 7.0: Change type from scaled_float to long and add format (#11982) #12158

merged 3 commits into from
May 16, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 10, 2019

Cherry-pick of PR #11982 to 7.0 branch. Original message:

I'm gonna try this one more time... A lot of scaled_float here in aws module does not need to be scaled_float, a long type should be sufficient here. Also, when I first started aws module, I didn't know about the defined format in Elasticsearch. This PR also adds format: bytes and format: duration into fields.yml.

  • Change type from scaled_float to long and add format

(cherry picked from commit 1b2613e)

@kaiyan-sheng kaiyan-sheng requested review from a team as code owners May 10, 2019 03:27
@kaiyan-sheng kaiyan-sheng self-assigned this May 10, 2019
@kaiyan-sheng kaiyan-sheng changed the title Cherry-pick to 7.0: Change type from scaled_float to long and add format (#11982) Cherry-pick #11982 to 7.0: Change type from scaled_float to long and add format (#11982) May 10, 2019
Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Stuff like this makes me wonder if there's any other metricsets floating around where we should be using the bytes format but we aren't.

@fearful-symmetry
Copy link
Contributor

Also, CI should pass if you rebase?

@kaiyan-sheng kaiyan-sheng merged commit 542b5f8 into elastic:7.0 May 16, 2019
@kaiyan-sheng kaiyan-sheng deleted the backport_11982_7.0 branch May 16, 2019 15:17
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ng and add format (elastic#11982) (elastic#12158)

* Change type from scaled_float to long and add format (elastic#11982)
(cherry picked from commit b97e5b7)
* Move changelog to Bugfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants